Comment 99 for bug 1585863

Revision history for this message
Olivier Tilloy (osomon) wrote :

While I don't have a xenial machine handy to test the bug and fix, I had a look at the debdiff for the packages in Aron's PPA, for some sanity checks.
The following patches have been added:

# fix for LP: #1585863
shared-add-nm_auto_close-and-nm_auto_fclose.patch
device-wwan-use-nm_auto_close-instead-of-gs_fd_close.patch
platform-add-a-new-function-nmp_utils_open_sysctl.patch
platform-refactor-wifi_utils_is_wifi-not-to-pass-sys.patch
platform-wifi-use-nmp_utils_open_sysctl-to-check-if-.patch
platform-refactor-nmp_utils_sysctl_open_netdir.patch
all-use-O_CLOEXEC-for-file-descriptors.patch
core-add-utils-for-file-handling.patch

The patches (which as far as I can tell are all cherrypicks from upstream commits) don't appear to be applied in chronological order (for instance platform-refactor-nmp_utils_sysctl_open_netdir.patch clearly uses a new function that was added by core-add-utils-for-file-handling.patch). Not that big of a deal if they apply cleanly, but applying them in chronological order would make it easier to review and maintain them.