Comment 8 for bug 1990903

Revision history for this message
dwmw2 (dwmw2) wrote :

Hm, that's odd. It should only actually be freeing anything there if the `num_headers` count is greater than zero. In which case it *should* have allocated `headers_array`. Unless the calloc() failed, but that is unlikely.

Then again, I'm looking at the upstream code. And that has had the check for `headers_array` being NULL since it was first committed in https://gitlab.gnome.org/GNOME/NetworkManager-openconnect/-/commit/9089be31#5122bcd6270f3f91d7aa6174306705bad477d30f_699_721

I'd suggest reconciling with the upstream version of the code.