Comment 11 for bug 1990903
Revision history for this message
| Konstantin (list-kseiler) wrote Re: [Bug 1990903] Re: Openconnect crashes on auth dialog | #11 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
This check for headers_array in the loop’s termination condition is only in the upstream code, not in the one that was in Ubuntu at the time I reported the bug and submitted the patch.
When I made the patch I decided to put a proper if-clause there because it’s easier to understand what is going on (the check in the for loop seems like obfuscated programming to me) and technically it’s even faster to check only once instead of at every loop iteration (even though this minimal performance gain is hardly significant here).