Ubuntu
netplan.io package

  1. Bug #1964481
  2. Comment #1

Comment 1 for bug 1964481

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This is a big SRU, especially with the API getting a nice refresh and cleanup. I like the idea of abi_compat.c for our stable series. Realistically speaking, we should not have any real users of libnetplan0 besides the bits in the NetworkManager snap, but I think it's good practice not to leave anyone 'hanging' just in case. Some of the symbols that got dropped, I think do not warrant an SONAME bump just yet.

After general review, this looks good to go - but there's one thing that we need to document in the debian/changelog. At least the impish upload includes the cherry-pick of 0002-cli-apply-fix-potential-race-with-rename-creation-of.patch which is not mentioned in the debian/changelog changes - and since it's a delta on top of 0.104, we need this documented.
From smaller nitpicks: changelog mentions changes to Standards-Version and debian/gbp.conf but none are done in this upload. Those could possibly get dropped?

Thanks!