Comment 7 for bug 2042644

Revision history for this message
Nick (kousu) wrote :

I've found the problem, it was this commit https://git.launchpad.net/ubuntu/+source/netdata/commit/debian/patches/upstream/0001-allow-symlinks.patch?h=applied/1.41.0-1&id=3b243dfbf6e6dfc45f29f4aea13442ab9f313e7b

That patch makes the code a no-op, with web_filename never getting filled in:

```
    char web_filename[FILENAME_MAX + 1];
    struct stat statbuf;
    if (stat(web_filename, &statbuf) != 0) {
         w->response.data->content_type = CT_TEXT_HTML;
         buffer_strcat(w->response.data, "File does not exist, or is not accessible: ");
         buffer_strcat_htmlescape(w->response.data, web_filename);
```

This was corrected in 1.43.0: https://git.launchpad.net/ubuntu/+source/netdata/commit/debian/patches/upstream/0001-allow-symlinks.patch?h=applied/1.43.0-1&id=1a9d47b69d9517476741e8bdaaf703adb5d19ac4 though I'm not sure if it was because it was trying to fix this bug; there's a note in the changelog that "Removing allow-symlinks.patch, not needed anymore (Closes: #1043415).", but https://bugs.launchpad.net/ubuntu/+source/netdata/+bug/1043415 is 404 for me so I am stumped. I guess it doesn't really matter though 😶

((and btw Debian is unaffected by this because they're further behind: they're only at netdata 1.29.3 which still has the `lstat()` call directly on that line instead of the `find_filename_to_serve()` helper.))

**So**: my request, please backport 1a9d47b69d9517476741e8bdaaf703adb5d19ac4 onto v1.41.1-1 and publish it as v1.41.1-2 so I can please use netdata again on my Mantic servers. Thank you :)