Ubuntu
net-snmp package

  1. Bug #1843036
  2. Comment #16

Comment 16 for bug 1843036

Revision history for this message
Eric Desrochers (slashd) wrote :

It is already upstream'ed via:

git show 71e487212b
commit 71e487212bd65839e7454df9701524d08cf0d74f
Author: Niels Baggesen <email address hidden>
Date: Thu Jul 21 21:45:26 2016 +0200

    fsys.h: put paranthesis around macros which are expressions

diff --git a/include/net-snmp/agent/hardware/fsys.h b/include/net-snmp/agent/hardware/fsys.h
index cd7880ce7..b540a53d4 100644
--- a/include/net-snmp/agent/hardware/fsys.h
+++ b/include/net-snmp/agent/hardware/fsys.h
@@ -33,14 +33,14 @@ typedef struct netsnmp_fsys_info_s netsnmp_fsys_info;
    /*
     * Additional enumerationis - not listed in that MIB
     */
-#define NETSNMP_FS_TYPE_IGNORE 1 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT
+#define NETSNMP_FS_TYPE_IGNORE (1 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT)

-#define NETSNMP_FS_TYPE_PROC 2 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT
+#define NETSNMP_FS_TYPE_PROC (2 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT)

-#define NETSNMP_FS_TYPE_DEVPTS 3 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT
-#define NETSNMP_FS_TYPE_SYSFS 4 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT
-#define NETSNMP_FS_TYPE_TMPFS 5 | _NETSNMP_FS_TYPE_LOCAL
-#define NETSNMP_FS_TYPE_USBFS 6 | _NETSNMP_FS_TYPE_LOCAL
+#define NETSNMP_FS_TYPE_DEVPTS (3 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT)
+#define NETSNMP_FS_TYPE_SYSFS (4 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT)
+#define NETSNMP_FS_TYPE_TMPFS (5 | _NETSNMP_FS_TYPE_LOCAL)
+#define NETSNMP_FS_TYPE_USBFS (6 | _NETSNMP_FS_TYPE_LOCAL)

 #define NETSNMP_FS_FLAG_ACTIVE 0x01
 #define NETSNMP_FS_FLAG_REMOTE 0x02

Only thing that need to be address upstream is the useless preprocessor HAVE_GETFSSTAT directive.