Comment 13 for bug 1907422

[Summary]
There does not appear to be any significant problems with this
package from MIR perspective, with the sole exception of the lack
of any test suite.

This does not need a security review

List of specific binary packages to be promoted to main:
  - needrestart

Notes:
Besides the TODOs listed below, this needs to wait for its
dependencies to be approved and promoted to main

Required TODOs:
Some kind of test suite should be added, and run (at least) at build
time.

Recommended TODOs:
The 'prerequisite not found' build warnings appear harmless, but could
be fixed (I think) by adding the packages to the Build-Dep list

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion

Problems:
- has other Dependencies to MIR due to this, which are all in progress using same LP bug
  - libintl-perl
  - libsort-naturally-perl
  - libmodule-scandeps-perl
  - libmodule-find-perl

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking

[Security]
OK:
- no CVEs
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)

[Common blockers]
OK:
- does not FTBFS currently
- The package has a team bug subscriber (foundations)
- has translation
- not a python/go package, no extra constraints to consider in that regard

Problems:
- does not have a test suite

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package (no Ubuntu delta)
- no massive Lintian warnings
- d/rules is rather clean
- Does not have Built-Using
- not Go package

[Upstream red flags]
OK:
- no incautious use of malloc/sprintf (as far as I can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
  (note: does include use of sudo in example config for nagios)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu or Upstream
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks

Problems:
- minor warnings during the build:
  Warning: prerequisite Module::ScanDeps 0 not found.
  Warning: prerequisite Proc::ProcessTable 0 not found.
  Warning: prerequisite Sort::Naturally 0 not found.
  Warning: prerequisite Term::ReadKey 0 not found.