Comment 75 for bug 40872

Revision history for this message
Bill Smith (snowmanam2) wrote :

Actually, the realignment approach was what I did with the modified first iteration of my patch. As you suggest, the code involved for this is incredibly simple. Also, after investigating the behavior of Windows XP, a similar method is used there. I do, however, disagree with the "realign every 2 seconds" concept. IMHO, the best way to implement this realignment approach is to put schedule_align_icons() (the function you're talking about) into nautilus_icon_container_add() and nautilus_icon_container_move_icon(). This way, whenever an icon is moved or added, the grid will be updated, and we wouldn't be aligning without reason.

Just to let you know, I discussed this on the Nautilus mailing list and on Bugzilla, and my patch was not accepted because the "move icons around" behavior was not desired. If case you are interested in code for this approach, I attached the patch I made earlier. Note this has an issue with renaming a new icon, but that could be fixed. Also, I should add that Nautilus bugs would best be discussed upstream (i.e. Nautilus Bugzilla). A number of reports appear there, including where I posted my patches ( https://bugzilla.gnome.org/show_bug.cgi?id=601469 ).