Comment 15 for bug 330272

Revision history for this message
MarcRandolph (mrand) wrote :

@Kevin,
Sorry, you are correct - I missed the mythcommflag angle somehow while I was rushing around this morning. I'm more than happy to leave this open for a while longer if you all can continue helping to debug it.

I did leave something out of my note earlier: MythContext:DBError() has been replaced by MythDB::DBError() in 0.22.
MythDB:DBError() does look cleaner / safer:

void MythDB::DBError(const QString &where, const QSqlQuery& query)
{
    QString str = QString("DB Error (%1):\n").arg(where);

    str += "Query was:\n";
    str += query.executedQuery() + '\n';
    QString tmp = toCommaList(query.boundValues());
    if (!tmp.isEmpty())
    {
        str += "Bindings were:\n";
        str += tmp;
    }
    str += DBErrorMessage(query.lastError());
    VERBOSE(VB_IMPORTANT, QString("%1").arg(str));
}

when compared to the old:

void MythContext::DBError(const QString &where, const QSqlQuery& query)
{
    QString str = QString("DB Error (%1):\n").arg(where);

    str += "Query was:\n";
    str += query.executedQuery() + "\n";
    str += QString::fromUtf8(DBErrorMessage(query.lastError()));
    VERBOSE(VB_IMPORTANT, QString("%1").arg(str));
}

... so I there still may be hope that this has been resolved, although I'm saying that with less certainty than I did earlier today :-). Regardless, if anyone is willing to try to keep digging, I'll do my best to support you all in your quest!