Comment 6 for bug 1820850

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

I have been asked to give a second opinion on this FFe so here I am.

Since I am not part of the Desktop team I'm deferring the decision of whether going with the PPA approach or the archive approach is the most optimal to the Desktop leads. Personally I also feel that using a PPA here might be more dynamic, but on the other hand I would always prefer 'official' bits and features to land in the archive. It's a tricky territory I must say. I guess because of our times with the stable-overlay PPA, I'm a bit shellshook regarding PPAs as 'semi-official delivery mechanisms' - but that's just me.
Anyway, as said, I'm leaving the decision of which one is better from the practical POV to the Desktop team, and so far I've been told that the management decision was made to get it into the archive.

With my release team hat on, to be able to approve this FFe I'd need to be sure that adding this feature so late in the cycle will not introduce regressions, therefore delaying the release. In this case, even though the change is quite big, I think the gsettings key makes this rather safe to land from this POV.

One thing I would not accept is blocking the disco release on this feature in any way. Like, once this 'disabled-by-default' feature lands in the archive but appears to be broken in some way that would delay our delivery of 19.04, to me this warrants an instant-revert instead.

With all this being said and some of the internal discussions I had with the Desktop team, I would like to approve this FFe under the above conditions. Sorry about that Laney - just so you know: your arguments were sane and it took me quite a bit to get convinced the other way around. I'll be taking the blame for it in case anything goes wrong.
Also, please land this ASAP and, at best, make sure this gets into the archive before the beta images are built. In case we notice anything wrong with the Beta images because of this, we can quickly revert and forget about it.