Comment 6 for bug 1864475

While trying to create a backport of mlxreg - without touching other parts of mstflint - I hit an incompatibility. See below. Does mlxreg require the new version of mget_max_reg_size(), or can it be made to work with the 4.8 version? The supports_reg_accces_gmp() interface will likely need to be added as well - I haven't checked to see how hairy that is. fyi, my working tree is at: https://git.launchpad.net/~dannf/+git/mstflint?h=master

libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -I. -I.. -I../ -I -I../mft_utils -I../include/mtcr_ul -Wall -W -DMST_UL -g -MP -MD -pipe -Werror -g -O2 -DHAVE_TERMIOS_H -DMST_UL -Wno-implicit-fallthrough -Wno-format-overflow -MT mlxreg_lib.lo -MD -MP -MF .deps/mlxreg_lib.Tpo -c mlxreg_lib.cpp -fPIC -DPIC -o .libs/mlxreg_lib.o
mlxreg_lib.cpp: In member function ‘bool mlxreg::MlxRegLib::isRegSizeSupported(std::string)’:
mlxreg_lib.cpp:330:94: error: too many arguments to function ‘int mget_max_reg_size(mfile*)’
  330 | ) <= (u_int32_t)mget_max_reg_size(_mf, MACCESS_REG_METHOD_SET)) ||
      | ^

In file included from mlxreg_lib.h:39,
                 from mlxreg_lib.cpp:36:
../include/mtcr_ul/mtcr.h:152:5: note: declared here
  152 | int mget_max_reg_size(mfile *mf);
      | ^~~~~~~~~~~~~~~~~
mlxreg_lib.cpp:331:94: error: too many arguments to function ‘int mget_max_reg_size(mfile*)’
  331 | ) <= (u_int32_t)mget_max_reg_size(_mf, MACCESS_REG_METHOD_GET)));
      | ^

In file included from mlxreg_lib.h:39,
                 from mlxreg_lib.cpp:36:
../include/mtcr_ul/mtcr.h:152:5: note: declared here
  152 | int mget_max_reg_size(mfile *mf);
      | ^~~~~~~~~~~~~~~~~
mlxreg_lib.cpp: In member function ‘bool mlxreg::MlxRegLib::isAccessRegisterGMPSupported(maccess_reg_method_t)’:
mlxreg_lib.cpp:374:19: error: ‘supports_reg_access_gmp’ was not declared in this scope
  374 | return (bool)(supports_reg_access_gmp(_mf, reg_method));
      | ^~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:607: mlxreg_lib.lo] Error 1