Comment 9 for bug 19934

Message-ID: <email address hidden>
Date: Sat, 1 Oct 2005 11:32:51 +0200
From: Sam Hocevar <email address hidden>
To: <email address hidden>
Subject: mpeg2dec: ftbfs [sparc] function 'arch_accel' can never be inlined because it uses setjmp

--TmwHKJoIRFM7Mu/A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

reopen 323134
severity 323134 normal
tag 323134 +patch
thanks

   The proper fix for this bug is not to disable optimisations. The
attached patch simply disables the inlining of the function that cannot
be inlined.

--
Sam.

--TmwHKJoIRFM7Mu/A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="patch-mpeg2dec-sparc-inline-setjmp.diff"

diff -puriN mpeg2dec-0.4.0/debian/rules mpeg2dec-0.4.0-new/debian/rules
--- mpeg2dec-0.4.0/debian/rules 2005-10-01 11:26:53 +0200
+++ mpeg2dec-0.4.0-new/debian/rules 2005-10-01 11:26:26 +0200
@@ -2,14 +2,6 @@

 DEB_HOST_ARCH := $(shell dpkg-architecture -qDEB_HOST_ARCH)

-# build with gcc 3.3 under sparc since it seems gcc 3.3 does not report
-# failure to inline setjmp() on sparc
-ifeq ($(DEB_HOST_ARCH),sparc)
-CC=gcc-3.3
-else
-CC=gcc-3.4
-endif
-
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/class/autotools.mk

diff -puriN mpeg2dec-0.4.0/libmpeg2/cpu_accel.c mpeg2dec-0.4.0-new/libmpeg2/cpu_accel.c
--- mpeg2dec-0.4.0/libmpeg2/cpu_accel.c 2003-10-06 04:31:52 +0200
+++ mpeg2dec-0.4.0-new/libmpeg2/cpu_accel.c 2005-10-01 11:27:39 +0200
@@ -157,7 +157,7 @@ static inline uint32_t arch_accel (void)
 #endif /* ARCH_PPC */

 #ifdef ARCH_SPARC
-static inline uint32_t arch_accel (void)
+static uint32_t arch_accel (void)
 {
     static RETSIGTYPE (* oldsig) (int);

--TmwHKJoIRFM7Mu/A--