Comment 41 for bug 239360

We should move on with this bug.
Today Mike Connor asked me to land bug 327181 very soon, but it must go in with some UI from this bug. Johnathan hasn't been able to address our last 20 comments with a new patch yet, so I'm trying to help out and trying to find a compromise. I propose I land something that works and addresses all technical concerns with the dialogs. We can produce a follow up patch that improves the wording and final visual tweaks to the dialog.

- in cert manager, renamed "Websites" tab to "Internet Sites"

- for consistency, I changed the groupbox-heading to "Internet Site"

- I kept the "Add Exception" button label

- for consistency, I changed the dialog's title to
    "Add Security Exception"
  and the button inside the dialog to
    "Confirm Security Exception"

- I addressed my own request (i) from comment 22

- I addressed the proposal to completely drop the "Port" field

- I used the proposal to pre-fill the Location field with
    https://
  I think that makes it clear for power users that a host:port can be entered.
  We can add a help button later, that explains this possibility.

- I removed the help button for now, as I don't know whether Johnathan
  will prefer that or an inline link, and we don't know have the help page yet.

- I moved the "get certificate" button to the right of the location field,
  in order to save space

- I renamed the "view certificate" button to "view" in order to save space,
  and moved it to the upper right of the cert status area.
  To me this looks nice, to have both "fetch" and "view" buttons aligned
  at the right and in the upper area of the dialog,
  so they are far away from the dialog confirmation buttons.
  But this is only a proposal, we can change this in a follow up patch.

- now, if there are multiple problems with the cert (up to 3),
  the dialog will display three paragraphs and bold headings.

- I reworded the strings for the status feedback.
  I removed everything that sounded like an suggestion.
  I attempted to explain the facts and risks as clearly as possible.

- I enhanced the behavior when a connection to the site is not possible,
  we will say "unable to obtain information" in that scenario.

- I added a new "Connection Failed" string, this will be helpful
  when we introduce the better cert-fetching-backend,
  we will be able to combine that heading with the detailed error message,
  e.g. "revoked" (instead of bringing up a popup box)

- I reverted my earlier change to move the bold warning to the bottom of
  the dialog. This seems a bit unusual, and I'd like to stick
  with Johnathan's proposal as much as possible.
  However, I still have the bold/non-bold reverted, as I had previously
  proposed.

I will attach a new patch and screenshots.

I will ask Johnathan for a quick UI-review, in the hope he is ok with this as an initial patch.

I will ask Bob for a code review.