Comment 15 for bug 239360

Revision history for this message
In , Kai Engert (kaie) wrote :

(In reply to comment #14)
> 1) The added exception does not appear in the web sites list. I need Kai's
> help figuring out how best to accomplish this, and think it needs to happen
> before the patch lands.

I agree, I just added a big patch to bug 327181.
I will need to improve and review it, and get review from rrelyea, but maybe you're interested to try it.

> 2) The dialog does not support non-https protocols. This is something we
> should support, but I think we should land this (and 327181) even without that
> support. It is launched off the "Web Sites" tab, and adds new functionality.
> I agree that we should file a follow-up to add broader support, but I don't
> think we need to block progress on our overall changes to SSL error handling
> based on this.

I agree that we can add support for any ports in a separate step.

> Of course, if anyone has a low touch solution for #2, that would be great, but
> if we can fix #1, I personally think the patch is ready for review.

I'll work on it, I probably should file a separate bug.