Comment 8 for bug 225797

Revision history for this message
In , Mkmelin+mozilla (mkmelin+mozilla) wrote :

(In reply to comment #6)
> (From update of attachment 234683 [edit])
> Renaming all of these variables, entity names, column ids, etc. seems like over
> kill.

Well since the semantic meaning does change a bit, the entity names should change so localizers will notice, no?

Ok, some variable names were changed just for code consistency. I can skip those changes of course, though I'd prefer changing them if you don't have a strong opinion about it... ;)

> Instead, why not make quick search on Sender (or From if we change the UI
> string) search both the Sender and the From header with an OR search.

Yeah, that sounds like a good idea!

---
Updating summary, quick search is really the smaller part of these changes.