Comment 44 for bug 105088

Comment on attachment 446488
Patch 0.6, warnings removed, Cancel removed

Thank you, Jan. This is looking good.

(In reply to comment #20)
> There is still no feedback when user aborts password dialog or fill wrong
> login/pass.

I don't think we need to sort that out in order to land this. The gnomevfs extension seems to leave no feedback on failure often enough.

>+ /* Calling g_file_mount_enclosing_volume creates a new thread */

Is this actually true? I thought typically it would start a new process and
send a dbus request. But really it could do anything. The key is that it is
asynchronous and the reply arrives on the main thread.

>+ /* Waiting for finish of mount operation thread */
>+ while (mMountRes == G_MOUNT_OPERATION_UNHANDLED)

I was initially worried that this might sometimes get set to
G_MOUNT_OPERATION_UNHANDLED as a GIO result of
g_file_mount_enclosing_volume().
But then I remembered that mMountRes is only set to internal values based on
the error from g_file_mount_enclosing_volume_finish.

I think it would be clearer to use an internal enum type for mMountRes with 3 values for the in-progress/failure/success states.