cosmic FTBFS

[Andreas Hasenack]

[Impact]
Multiple FTBFS errors when building mongodb in cosmic. This prevents mongodb from being SRUed, and such an SRU need has appeared in bug #1821391. The FTBFS issues in cosmic are:

- new gcc8 warnings (format-truncation and class-memaccess)
- -Wparentheses warning
- incompatibility with boost1.66+

There is an additional fix needed for boost1.67 itself, which is being handled in bug #1821762.

[Test Case]
Rebuild mongodb in cosmic. Without these fixes, the build will fail.
[Regression Potential]
All but the fix in boost1.67 mentioned above are due to new gcc8 checks, which suggests that mongodb was last built in cosmic before gcc8 became default.

[Other Info]
Mongo upstream nowadays has proper fixes for the format-truncation and class-memaccess warnings, but these were done[1] after the switch to the SSPL license[2] on October 16th, 2018. What I have done here is grab the fix we currently have in disco which was done by upstream[3] before that date.

[Original Description]

mongodb 3.6.3 is currently failing to build in cosmic.

https://launchpadlibrarian.net/416133571/buildlog_ubuntu-cosmic-amd64.mongodb_1%3A3.6.3-0ubuntu1.18.10.1_BUILDING.txt.gz

They all seem to be about Werror=class-memaccess. Example:
src/mongo/db/pipeline/value_internal.h:194:42: error: 'void* memmove(void*, const void*, size_t)' writing to an object of type 'class mongo::ValueStorage' with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Werror=class-memaccess]
         memmove(this, &rhs, sizeof(*this));
                                          ^
src/mongo/db/pipeline/value_internal.h:78:7: note: 'class mongo::ValueStorage' declared here

And, of course:
cc1plus: all warnings being treated as errors

1. https://github.com/mongodb/mongo/commit/76b0fcea6960274d23a3bd1245a0e55e3cb08369 and https://github.com/mongodb/mongo/commit/f53ed89cef7c4356789114b2de1a5294e3d7a6f7
2. https://www.mongodb.com/licensing/server-side-public-license/faq
3. https://github.com/mongodb/mongo/commit/168c8d65556ab18b05e33b5f4006d1184c30f8f7

[Andreas Hasenack (ahasenack)]

Uploaded to cosmic.

[Timo Aaltonen (tjaalton)]

Hello Andreas, or anyone else affected,

Accepted mongodb into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mongodb/1:3.6.3-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

The package build in cosmic-proposed: https://launchpad.net/ubuntu/+source/mongodb/1:3.6.3-0ubuntu2.1

cosmic verification succeeded

[Andreas Hasenack (ahasenack)]

dep8 tests are also green for mongodb in cosmic.

[Launchpad Janitor (janitor)]

This bug was fixed in the package mongodb - 1:3.6.3-0ubuntu2.1

---------------
mongodb (1:3.6.3-0ubuntu2.1) cosmic; urgency=medium

  * d/p/SERVER-36951-applyOps-createIndexes-without-uuid.patch: fix restoring
    of a database backup when applyOps has a createIndexes command without a
    UUID. (LP: #1821391)
  * Fix several FTBFS issues (LP: #1821361):
    - d/p/168c8d65556ab18b05e33b5f4006d1184c30f8f7.patch: copy patch from
      disco to disable new gcc 8.2 warnings
    - d/p/gcc8-parentheses.patch: Remove enclosing parentheses from the _F()
      macro to avoid a gcc8 -Wparentheses complaint
    - d/p/fix-boost-compile.patch: fix build with newer boost

 -- Andreas Hasenack <email address hidden> Thu, 28 Mar 2019 11:26:03 -0300

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for mongodb has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.