Fix regression (vs 1.66.0 and older) to allow argc == 0 for command_line parser

[Andreas Hasenack]

[Impact]

Mongodb in cosmic doesn't build with boost1.67[1].

This bug prevents mongodb from being SRUed[4]. The patch in the upstream PR[2] for boost1.67 was taken for the disco boost1.67 package[3] to fix this for disco.

[Test Case]
The test case if building mongodb in cosmic. Without this update to boost1.67, mongodb will fail to build due to a test failure.

[Regression Potential]
This is already fixing a regression from boost1.67. Upstream isn't yet convinced that the previous behavior is correct, but abandoned the discussion in the PR[2], which remains open.

[Other Info]
Both the boost1.67 PR[2] and the mongodb bug[1] remain open upstream, but we have adopted the boost1.67 fix from that PR for disco onwards. If mongodb comes up with a change of their own, it will be under their new license[5], which might be an issue for us.

[Original Description]

This 1.67 change broke a specific mongodb test[1], and is one of the remaining mongodb FTBFS issues in Cosmic.

Upstream PR[2] is still open.

Disco has[3] the patch since boost1.67 (1.67.0-9).

1. https://jira.mongodb.org/browse/SERVER-37282
2. https://github.com/boostorg/program_options/pull/59
3. https://git.launchpad.net/~usd-import-team/ubuntu/+source/boost1.67/tree/debian/patches/boostorg-program_options-pull-59.patch?h=ubuntu/disco-devel
4. https://bugs.launchpad.net/ubuntu/+source/mongodb/+bug/1821391
5. https://www.mongodb.com/licensing/server-side-public-license/faq

[Andreas Hasenack (ahasenack)]

This is fixed in disco.

[Robie Basak (racb)]

Hello Andreas, or anyone else affected,

Accepted boost1.67 into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/boost1.67/1.67.0-7ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Andreas Hasenack (ahasenack)]

mongodb built successfully on cosmic-proposed:

https://launchpad.net/ubuntu/+source/mongodb/1:3.6.3-0ubuntu2.1

As explained in https://bugs.launchpad.net/ubuntu/+source/boost1.67/+bug/1821803/comments/2, though, there is a dep8 failure in "mothur" that I haven't been able to reproduce locally. https://bugs.launchpad.net/ubuntu/+source/boost1.67/+bug/1821803/comments/3 has a log file of a local dep8 run attached, showing it worked just fine in a cosmic/i386 VM with proposed enabled.

[Andreas Hasenack (ahasenack)]

I added some debugging around that area:
if(parameter.compare("precision") == 0) {
    double logNum = log10((double)pVal);
    double diff = (double)((int)logNum - logNum);
    if(diff != 0) {
        m->mothurOut("The precision parameter can only take powers of 10 as a value (e.g. 10,1000,1000, etc.)\n");
        m->mothurOut("diff: " + toString(diff) + "logNum: " + toString(logNum) + "pVal: " + toString(pVal) + "\n");
        return false;
    }
}

And this is the output in bileto/i386, where it fails too:
mothur > cluster(method=furthest, column=HA.unique.dist, name=HA.names, cutoff=0.01, precision=1000)
The precision parameter can only take powers of 10 as a value (e.g. 10,1000,1000, etc.)
diff: -2.1684e-19logNum: 3pVal: 1000

[Andreas Hasenack (ahasenack)]

The test in bileto isn't even using my boost proposed package, so this is an already existing issue in cosmic/i386 exclusively on the bileto/autopkgtest infra as far as I can tell.

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for boost1.67 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package boost1.67 - 1.67.0-7ubuntu0.1

---------------
boost1.67 (1.67.0-7ubuntu0.1) cosmic; urgency=medium

  * d/p/boostorg-program_options-pull-59.patch: pulled in patch from disco to
    fix regression (vs 1.66.0 and older) to allow argc == 0 (LP: #1821762)
  * d/p/fix-boost-compute-gcc8-ftbfs.patch: Fix FTBFS in boost.compute with
    GCC-8 (LP: #1821803)

 -- Andreas Hasenack <email address hidden> Tue, 26 Mar 2019 17:06:29 -0300