Comment 9 for bug 221243

Revision history for this message
Peter Bienstman (peter-bienstman) wrote : Re: [Bug 221243] Re: mnemosyne crashed with AttributeError in import_XML()

On Saturday 02 August 2008 16:39:58 Scott Kitterman wrote:
> We had one other change from upstream that we inherited from Debian:
>
> --- mnemosyne-1.0.2.orig/mnemosyne/pyqt_ui/mnemosyne
> +++ mnemosyne-1.0.2/mnemosyne/pyqt_ui/mnemosyne
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/python2.4
>
> Personally, I'd say these are both wrong. Debian shouldn't be forcing
> to 2.4 when you support 2.5 (2.5 is the default in Debian too) and I
> don't think you should depend on /usr/bin/env. I think it's a fragile
> solution. For people installing via setup.py, distutils will insert the
> correct interpreter version if needed, so it's unnecessary for them and
> a problem for distro developers. The best thing is just to use
> /usr/bin/python.

OK, feel free to patch 1.1 as you see fit, I'll add the patch to SVN.

> Looking at the code in 1.1, I don't see that it handles this error any
> differently (I just looked where it crashed, I don't have a deep
> understanding of your code). Is it caught somewhere else so we can mark
> this fixed after I upload 1.1?

The error is not handled differently, but the conditions that give rise to the
error should no longer occur.

Peter