Comment 6 for bug 1094324

Revision history for this message
Mantas Kriaučiūnas (mantas) wrote :

Hi Yury,

Yury V. Zaytsev (zyv) wrote on 2013-03-05:
> I pushed upstream a different patch from what you suggested, but I believe it should still work.

Your patch doesn't fix the problem - I'm attaching correct patch against mc.menu from mc 4.8.8 which fixes identical files deletion when folders and/or files names contains spaces.
Problem in your patch was quoted %D - see this line in your patch:
  if [ -f "%D/$i" ]; then
because of quoted %D deletion doesn't work: mc doesn't even find identical files - I get a message "FILENAME has no copy in /tmp/folder\ with\ space: NOT deleted." in terminal.
Deletion works correctly when %D isn't quoted, only $i is quoted:
  if [ -f %D/"$i" ]; then

I hope you understand why your patch doesn't work and you will forward my patch to mc upstream ;)