Thanks for finding this. Looks like fixed_network and fixed_subnet must both be specified, else things break apart at the heat driver layer.
- fixed-network without fixed-subnet = heat can't find subnet with error "Multiple subnet matches found for name '', use an ID to be more specific."
- fixed-subnet without fixed-network = heat template doesn't use the subnet due to the detection at [1]
I think it is fair that there are some validation to make sure network / subnet exist. But I'm not sure if we should validate that both of them exist together in the api/attr_validation.py layer. Future driver implementation may only need one and not the other. If Heat needs both, Heat should validate it.
Can we move forward by simply validating subnet exists like how you did with network?
Hi Felipe,
Thanks for finding this. Looks like fixed_network and fixed_subnet must both be specified, else things break apart at the heat driver layer.
- fixed-network without fixed-subnet = heat can't find subnet with error "Multiple subnet matches found for name '', use an ID to be more specific."
- fixed-subnet without fixed-network = heat template doesn't use the subnet due to the detection at [1]
I think it is fair that there are some validation to make sure network / subnet exist. But I'm not sure if we should validate that both of them exist together in the api/attr_ validation. py layer. Future driver implementation may only need one and not the other. If Heat needs both, Heat should validate it.
Can we move forward by simply validating subnet exists like how you did with network?
[1] https:/ /opendev. org/openstack/ magnum/ src/branch/ stable/ 2023.2/ magnum/ drivers/ heat/template_ def.py# L591