Comment 1 for bug 1772010

SRU review:

Potentially breaking changes should be brought to the attention of the SRU team. Based on a detailed review of the proposed changes, this does not currently seem to be happening. I've (non-exhaustively) detailed the proposed changes that bring me concern below.

This also seems to mismatch the definition of a MAAS point release in the draft (currently on version 7) of

List of changes in behaviour to existing users that suggest to me a backwards compatibility break:

Bug 1767137 "Default install is now importing bionic by default instead of xenial" [this "fix" will change the current default behaviour in stable Ubuntu releases]

Bug 1742703 "Virsh pod: autostart for created virtual machines is not enabled"

Bug 1741165 "Deleting a machine from a KVM pod doesn't delete its disk image"

General Feature additions:

Bug 1730751 "LACP rate fast by default"

Bug 1704501 "Can't change which fabric a vlan belongs to"

Bug 1738127 "[enhancement] MAAS doesn't have a favicon"

Bug 1739761 [adds support to deploy Precise on MAAS 2.3]

Please provide justifications for each of the changes (listed above, and any others that I missed) that are going into this potential update to MAAS that have the potential to break backward compatibility. Also please itemize new features, as is written in the MAASUpdates wiki page.

The following I note because I was expecting that this point release contained bugfixes only (based on the definition of a point release on your proposed SRU policy page), but also found unexpected feature additions. I understand there is a current exception request in process, and feature updates are expected in some cases, but those feature and backward compatibility changes should be called out as such directly in the SRU bug.

These Hardware enablement related feature additions also took me by surprise since they don’t fit into the “point release” definition in the MAASUpdates wiki page. Shouldn’t this then be a “2.4” release (“new upstream releases” in the document)?

Bug 1750622 "[feature] Add ability to select the BIOS boot method for IPMI - To address issues with newer firmware"

Bug 1758760 "[enhancement] Support Lenovo’s new password policy (Lenovo SR550)"

To move forward, please itemize the potential backward compatibility breaking changes in this proposed SRU, and clear up the confusion on hardware enablement changes coming in via a “new upstream point release” as defined in MAASUpdates.