Comment 33 for bug 2039873

I imported your noble debdiff and pushed to this branch:

https://code.launchpad.net/~ahasenack/ubuntu/+source/lxc/+git/lxc/+ref/noble-lxc-drop-devel-2039873

If you run "git ubuntu clone lxc; cd lxc; git ubuntu remote add ahasenack; git checkout noble-lxc-drop-devel-2039873" you should have a local copy. Or if using just git, not git-ubuntu, follow the instructions from the URL above.

Regarding the new d/t/build dep8 test:

"""
d/t/control:
Tests: build
Restrictions: allow-stderr superficial

d/t/build:
#!/bin/sh
# autopkgtest check: very basic checks to ensure that LXC package is in a good shape

set -eux

# ensure that LXC_DEVEL is 0
grep "LXC_DEVEL" meson.build | grep 0
"""

a) being marked as superficial won't block a migration if it fails (IIRC: at least, it's definitely not a hard error). And we do want this to "stop the line" if it fails, right?

b) it's checking something from the source code, which could be later changed via d/rules during build. What I mean is that this is not the place users will get the value of LXC_DEVEL from. We should be checking the include file that gets installed on the user's system, either via grep, or preferably a small C program that includes that version.h file and checks the value of LXC_DEVEL.

c) A DEP8 test is awesome, thanks for that. But it might too close to a release for such a check. Imagine an SRU gets sponsored, then reviewed, then accepted, and then we get the DEP8 result that says "oops, LXC_DEVEL=1 is leaking again". How about also checking it during package build? I won't block the upload on this, though, but it would be good to have I think, even if later.

What are your thoughts on (a) and (b)?