Comment 21 for bug 2039873
Revision history for this message
| Dave Jones (waveform) wrote Re: liblxc-dev was built with LXC_DEVEL=1 in Ubuntu 22.04 and later releases | #21 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Thanks very much for the updated debdiff. There's a lot of changes here to look at and unfortunately I've run out of time looking through it all during my patch-pilot shift, but here's what I've got so far:
The major thing that I think needs correction is that this patch is built on top of ubuntu/noble-devel by importing the upstream 5.0.3, but what Stéphane suggested in comment 14 was to take the Debian upstream (currently 5.0.3-2) and build on top of that. In this case, the commits in the repo would be based on debian/sid rather than ubuntu/noble-devel. This would ensure we incorporate the changes Debian has placed on top of lxc, as well as our own (and means in future we can follow the git-ubuntu merge process for this package).
The proposed changes also include package renames (which will be necessary if we're basing off the upstream Debian version). As far as I can tell they look sane but I haven't dug deep into this bit yet (it's something I always need to read the policy guides and manuals for!).
The requested autopkgtest to ensure LXC_DEVEL==0 is present, and looks good.
I have to dash to an appointment now, but I'll try and add some more notes later this evening.