Comment 19 for bug 1576341

Revision history for this message
Nish Aravamudan (nacc) wrote : Re: fails in lxd container

Did some digging on the mlockall failure:

        /* we don't want our active sessions to be paged out... */
        if (mlockall(MCL_CURRENT | MCL_FUTURE)) {
                log_error("failed to mlockall, exiting...");
                log_close(log_pid);
                exit(ISCSI_ERR);
        }

so I think it's a real issue for iscsid (and I'm not sure we want to debug random failures in the code if it can't ensure it's 'active sessions') don't stay in memory.

That change, fwiw, was originally introduced in 2005:

https://github.com/open-iscsi/open-iscsi/commit/6f37c861162157f4a6e28c2fa3cf50e61726c8f3

so it's unlikely to have been tested anytime recently without it :)