Comment 8 for bug 2052294

Revision history for this message
Nick Rosbrook (enr0n) wrote :

Thanks for the updated debdiffs. Two quick things I should have mentioned in my first review:

(1) In the future, remember to include (LP: #NNNNNNN) for the fixed bugs (i.e. this tracking bug in this case).
(2) With merges, it is convention to "strip" bug numbers for already-fixed bugs. The preferred way to do this is to change (LP: #NNNNNNN) -> (LP NNNNNNN). This prevents the bug from being added to the Launchpad-Bugs-Fixed: field in the .changes, but leaves enough human-readable context.

Since these are easy changes, I have gone ahead and made them myself prior to uploading. Thanks again!