Comment 1 for bug 1537116

So I uploaded lsvpd to the xenial archive with this change; but then after testing, I see that it merely trades one set of errors for another.

 - iprconfig is not shipped as /usr/sbin/iprconfig in Ubuntu, but as /sbin/iprconfig; so adding the dependency does not remove the error.
 - adjusting paths so that vpdupdate can find iprconfig results in a new stream of other error messages when invoking vpdupdate:
iprconfig[91936]: Could not open /dev/sg28. No such file or directory
iprconfig[91936]: Could not open /dev/sg28. No such file or directory
iprconfig[91936]: Could not open /dev/sg28. No such file or directory
iprconfig[91936]: Could not open /dev/sg28. No such file or directory
iprconfig[91936]: Could not open /dev/sg28. No such file or directory
iprconfig[91936]: Could not open /dev/sg25. No such file or directory
iprconfig[91936]: Could not open /dev/sg25. No such file or directory
iprconfig[91936]: Could not open /dev/sg25. No such file or directory
iprconfig[91936]: Could not open /dev/sg25. No such file or directory
iprconfig[91936]: Could not open /dev/sg25. No such file or directory
iprconfig[91936]: Could not open /dev/sg25. No such file or directory
iprconfig[91936]: Could not open /dev/sg30. No such file or directory
iprconfig[91936]: Could not open /dev/sg30. No such file or directory
iprconfig[91936]: Could not open /dev/sg30. No such file or directory
iprconfig[91936]: Could not open /dev/sg30. No such file or directory
iprconfig[91936]: Could not open /dev/sg30. No such file or directory
iprconfig[91936]: Could not open /dev/sg30. No such file or directory

(etc)

- after running vpdupdate with fixed paths, the output of 'lsvpd' is almost precisely identical from before. Only two lines of diference in the output, and it appears that the new output contains less information rather than more?

@@ -422,7 +422,7 @@
 *XB 3
 *XT 0
 *XL 0
-*YL U78CB.001.WZS008E-P1-C14-B3-T0-L0
+*YL U78CB.001.WZS008E-P1-C14
 *FC
 *DS -SCSI Enclosure Services Device
 *AX sg27
@@ -970,7 +970,7 @@
 *XB 3
 *XT 0
 *XL 0
-*YL U78CB.001.WZS008E-P1-C15-B3-T0-L0
+*YL U78CB.001.WZS008E-P1-C15
 *FC
 *DS -SCSI Disk Drive
 *AX sg39

Perhaps because this particular system doesn't support ipr scsi? Or perhaps, it's because if iprutils aren't installed, one can assume that ipr scsi isn't configured and therefore iprconfig is not going to provide any additional information...

So I'm not sure that the dependency on iprutils is actually required. But I am reasonably certain that vpdupdate should be fixed to suppress error output from iprconfig instead of displaying it.

Please consider whether making this change to lsvpd upstream is a better fix.

For reference, here is the output of 'iprconfig -c show-config 2>/dev/null' on the system where I tested:
Name PCI/SCSI Location Description Status
------ ------------------------- ------------------------- -----------------
       0001:08:00.0/0: PCI-E SCSI Adapter Not Operational
sda 0001:08:00.0/0:2:0:0 Unavailable Device Unknown
sdb 0001:08:00.0/0:2:1:0 Unavailable Device Unknown
sdc 0001:08:00.0/0:2:2:0 Unavailable Device Unknown
sdd 0001:08:00.0/0:2:3:0 Unavailable Device Unknown
sde 0001:08:00.0/0:2:4:0 Unavailable Device Unknown
sdf 0001:08:00.0/0:2:5:0 Unavailable Device Unknown
sdg 0001:08:00.0/0:2:6:0 Unavailable Device Unknown
sdh 0001:08:00.0/0:2:7:0 Unavailable Device Unknown
       0001:08:00.0/0:0:11:0 Enclosure Unknown
       0001:08:00.0/0:0:12:0 Enclosure Unknown
       0001:08:00.0/0:0:8:0 Enclosure Unknown
       0003:04:00.0/1: PCI-E SCSI Adapter Not Operational
sdi 0003:04:00.0/1:2:0:0 Unavailable Device Unknown
sdj 0003:04:00.0/1:2:1:0 Unavailable Device Unknown
sdk 0003:04:00.0/1:2:2:0 Unavailable Device Unknown
sdl 0003:04:00.0/1:2:3:0 Unavailable Device Unknown
sdm 0003:04:00.0/1:2:4:0 Unavailable Device Unknown
sdn 0003:04:00.0/1:2:5:0 Unavailable Device Unknown
sdo 0003:04:00.0/1:2:6:0 Unavailable Device Unknown
sdp 0003:04:00.0/1:2:7:0 Unavailable Device Unknown
       0003:04:00.0/1:0:1:0 Enclosure Unknown
       0003:04:00.0/1:0:2:0 Enclosure Unknown