Comment 13 for bug 1010602

Since this bug had been inactive for quite a while previously the original reporter may no longer be following it.

I tested out the version in proposed, and can verify that the version in proposed finds the samba logs correctly. Since the patch only adds an additional rule to match the samba log files and does not remove the old rule, there is no real regression potential, other than users seeing output samba messages in their logwatch output that they had not been seeing before.

Verification procedure (note that samba was not configured and was did not start. the failure messages from it were still picked up by logwatch with the fix applied though. note also that if logwatch not matching the samba startup failure messages is considered a bug, it is separate from logwatch not reporting the samba logs at all):

root@unissuable-cade:~# apt-cache show logwatch | grep Version
    Version: 7.4.0+svn20130529rev144-1ubuntu1
root@unissuable-cade:~# sudo apt-get install samba
root@unissuable-cade:~# sudo service samba restart
        nmbd stop/waiting
        nmbd start/running, process 12562
        smbd stop/waiting
        smbd start/running, process 12574
        stop: Unknown instance:
        samba-ad-dc start/running, process 12589
root@unissuable-cade:~# logwatch --detail high --logdir /var/log/ --range all --service samba
    # no output, but /var/log/samba/log.%m has contents from restarting

root@unissuable-cade:/usr/share/logwatch/scripts# apt-cache show logwatch | grep Version
    Version: 7.4.0+svn20130529rev144-1ubuntu1.1
    Version: 7.4.0+svn20130529rev144-1ubuntu1
root@unissuable-cade:~# logwatch --detail high --logdir /var/log/ --range all --service samba

         ################### Logwatch 7.4.0 (05/29/13) ####################
                        Processing Initiated: Tue Sep 27 17:51:44 2016
                        Date Range Processed: all
                        Detail Level of Output: 10
                        Type of Output/Format: stdout / text
                        Logfiles for Host: unissuable-cade
         ##################################################################

         --------------------- samba Begin ------------------------

         **Unmatched Entries**
         ../lib/util/become_daemon.c:111(exit_daemon) STATUS=daemon failed to start: Samba detected misconfigured 'server role' and exited. Check logs for details, error code 22 : 3 Time(s)
         ../lib/util/become_daemon.c:124(daemon_ready) STATUS=daemon 'nmbd' finished starting up and ready to serve connections : 2 Time(s)
         ../lib/util/become_daemon.c:124(daemon_ready) STATUS=daemon 'smbd' finished starting up and ready to serve connections : 2 Time(s)
         ../source4/smbd/server.c:477(binary_smbd_main) At this time the 'samba' binary should only be used for either: 'server role = active directory domain controller' or to access the ntvfs file server with 'server services = +smb' or the rpc proxy with 'dcerpc endpoint servers = remote' You should start smbd/nmbd/winbindd instead for domain member and standalone file server tasks : 3 Time(s)

         ---------------------- samba End -------------------------

         ###################### Logwatch End #########################