Comment 53 for bug 1488254

Hi Stefan,

(In reply to comment #47)
> I think the attributes part of the patch is quite good compared with
> the mangling part... perhaps it should be split into a separate patch.
>
> Regarding the mangling I'm not too happy with my patch. I don't understand
> what most of the mangling code did before to actually know where
> to insert the tagging code. This is C++ on a level I don't usually touch;
> I'm not familiar with all the terms (<unscoped-template-name>,
> <source-name>, ...) and just keep guessing what they do.
>
> Also I don't like using recursion to determine the inherited abi tags;
> I think using temporary strings instead of directly writing to the stream
> would solve this.
>
> All in all I hoped to get some feedbacks how things are done or should
> look like; I don't mind if someone else wants to take over and rewrite
> the mangling :)

Sure -- I will ask someone from Intel compiler team to handle mangling part. We are co-located with Intel GCC team, so it's easy for us to ask on intricacies of GCC implementation. :-)

I don't see attribute part of the patch to be reviewed, though -- we can help with this as well. (Though the real authority to approve it belongs to Aaron, so it's better to wait for his review (and ping if there is no reply from his after a week)).

Yours,
Andrey