ubuntu-cpc: Exit on first failure for extra hooks

Bug #1687752 reported by Robert C Jennings on 2017-05-02
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
livecd-rootfs (Ubuntu)
Undecided
Unassigned
Xenial
Undecided
Unassigned
Yakkety
Undecided
Unassigned
Zesty
Undecided
Unassigned

Bug Description

[Impact]

 * When running extra binary hooks for the ubuntu-cpc project, exit on first failure rather than running all hooks.

 * This allows ubuntu-cpc to fail fast and find errors more easily. This change has been made in devel and proves very useful.

[Test Case]

 * Add binary hooks to the extra directory where one hook exits non-zero. Ensure build returns an error at that point rather than run-parts continuing after the initial failure

[Regression Potential]

 * Low risk, any non-zero exit will fail the build with or without this patch. Now we'll fail optimally for the first failure.

==== Original description ====

This was fixed(improved?) in devel with r1464.1.2. I have opened this bug to back-port these to zesty, yakkety, and xenial.

The attachment "xenial debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Brian Murray (brian-murray) wrote :

The debdiffs are missing references to this bug, something which is required for the SRU process.

Robert C Jennings (rcj) wrote :

Updated to list bug # in changelog

Robert C Jennings (rcj) wrote :

Updated to have bug # in changelog

Robert C Jennings (rcj) wrote :

Updated to have bug # in changelog

description: updated
Brian Murray (brian-murray) wrote :

I'm handling the sponsoring of these.

Changed in livecd-rootfs (Ubuntu Zesty):
status: New → In Progress
Brian Murray (brian-murray) wrote :

This has been fixed in artful.

livecd-rootfs (2.442) artful; urgency=medium

  [ Robert Jennings ]
  * live-build/ubuntu-cpc/hooks/060-ipv6.chroot: remove faulty release
    comparison prior to aa-series (LP: #1681548)
  * live-build/ubuntu-cpc/hooks/999-extras.binary: Exit on first failure

Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released
Changed in livecd-rootfs (Ubuntu Yakkety):
status: New → In Progress
Changed in livecd-rootfs (Ubuntu Xenial):
status: New → In Progress

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.441.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in livecd-rootfs (Ubuntu Zesty):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in livecd-rootfs (Ubuntu Yakkety):
status: In Progress → Fix Committed
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.435.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in livecd-rootfs (Ubuntu Xenial):
status: In Progress → Fix Committed
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.408.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Robert C Jennings (rcj) wrote :

I have tested the proposed package for xenial, yakkety, and zesty. The processing of extra hooks exits on first failure as expected. Thank you.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.441.3

---------------
livecd-rootfs (2.441.3) zesty; urgency=medium

  * live-build/ubuntu-cpc/hooks/999-extras.binary: Exit on first failure.
    (LP: #1687752)

 -- Robert C Jennings <email address hidden> Tue, 09 May 2017 13:46:01 -0700

Changed in livecd-rootfs (Ubuntu Zesty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.435.3

---------------
livecd-rootfs (2.435.3) yakkety; urgency=medium

  * live-build/ubuntu-cpc/hooks/999-extras.binary: Exit on first failure.
    (LP: #1687752)

 -- Robert C Jennings <email address hidden> Tue, 09 May 2017 13:49:48 -0700

Changed in livecd-rootfs (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.408.12

---------------
livecd-rootfs (2.408.12) xenial; urgency=medium

  * live-build/ubuntu-cpc/hooks/999-extras.binary: Exit on first failure.
    (LP: #1687752)

 -- Robert C Jennings <email address hidden> Tue, 09 May 2017 13:57:44 -0700

Changed in livecd-rootfs (Ubuntu Xenial):
status: Fix Committed → Fix Released
tags: added: id-58ff759a4e904f9e97018edd
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers