On Tue, Mar 20, 2012 at 9:27 AM, Jeremy Kerr <email address hidden> wrote: > From: Benjamin Herrenschmidt <email address hidden> > > BugLink: https://bugs.launchpad.net/bugs/959959 > > The code for "powersurge" SMP would kick in and cause a crash > at boot due to the lack of a NULL test. > > Signed-off-by: Benjamin Herrenschmidt <email address hidden> > Signed-off-by: Jeremy Kerr <email address hidden> > Reported-By: Adam Conrad <email address hidden> > Tested-By: Adam Conrad <email address hidden> > > Cherry-picked from upstream commit > 78c5c68a4cf4329d17abfa469345ddf323d4fd62 > > --- > arch/powerpc/platforms/powermac/smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c > index 9b6a820..3394254 100644 > --- a/arch/powerpc/platforms/powermac/smp.c > +++ b/arch/powerpc/platforms/powermac/smp.c > @@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = { > > static void __init smp_psurge_setup_cpu(int cpu_nr) > { > - if (cpu_nr != 0) > + if (cpu_nr != 0 || !psurge_start) > return; > > /* reset the entry point so if we get another intr we won't > > -- > kernel-team mailing list > <email address hidden> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
Why not CC: lkml ?
It is on the stable channel ? Upstream link please ? Now you understand Greg's concerns about maintaining a stable kernel ?
On Tue, Mar 20, 2012 at 9:27 AM, Jeremy Kerr <email address hidden> wrote: /bugs.launchpad .net/bugs/ 959959 d17abfa469345dd f323d4fd62 platforms/ powermac/ smp.c | 2 +- powerpc/ platforms/ powermac/ smp.c b/arch/ powerpc/ platforms/ powermac/ smp.c powerpc/ platforms/ powermac/ smp.c powerpc/ platforms/ powermac/ smp.c setup_cpu( int cpu_nr) /lists. ubuntu. com/mailman/ listinfo/ kernel- team
> From: Benjamin Herrenschmidt <email address hidden>
>
> BugLink: https:/
>
> The code for "powersurge" SMP would kick in and cause a crash
> at boot due to the lack of a NULL test.
>
> Signed-off-by: Benjamin Herrenschmidt <email address hidden>
> Signed-off-by: Jeremy Kerr <email address hidden>
> Reported-By: Adam Conrad <email address hidden>
> Tested-By: Adam Conrad <email address hidden>
>
> Cherry-picked from upstream commit
> 78c5c68a4cf4329
>
> ---
> arch/powerpc/
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/
> index 9b6a820..3394254 100644
> --- a/arch/
> +++ b/arch/
> @@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = {
>
> static void __init smp_psurge_
> {
> - if (cpu_nr != 0)
> + if (cpu_nr != 0 || !psurge_start)
> return;
>
> /* reset the entry point so if we get another intr we won't
>
> --
> kernel-team mailing list
> <email address hidden>
> https:/
Why not CC: lkml ?
It is on the stable channel ? Upstream link please ?
Now you understand Greg's concerns about maintaining a stable kernel ?