Comment 8 for bug 883748

Revision history for this message
Ming Lei (tom-leiming) wrote : Re: [Bug 883748] Re: Suspend/resume corrupts external data storage devices

On Tue, Nov 1, 2011 at 5:55 AM, Steve <email address hidden> wrote:
>> You may not umount successfully if accesses to the filesystem is
>> pending or ongoing.
>
> Yes, that is exactly the point. If you cannot unmount, you cannot and
> SHOULD NOT suspend. So, if the user clicks Suspend and everything in
> /media cannot be unmounted, you give an error instead of suspending.

It will make user confused if suspend operation is just failed because of
a usb mass storage device connected and some directories or files are open,
looks like it is a bit stupid, doesn't it?

Just check for /media is still not enough too, someone may mount external
block devices under other directories.

thanks,
--
Ming Lei