Comment 66 for bug 440411

Revision history for this message
Mikko Rantalainen (mira) wrote :

Nicholas: is that patch really correct? The proposed patch at freedesktop.org uses "|=" operator with value zero and your patch uses operator "=" with value zero. As a result, your patch will reset all bits in the bit mask hotplug_supported_mask opposed to doing practically nothing in the freedesktop.org patch (any number X binary OR with zero is always X).

Obviously, the patch will prevent any HDMI hotplugging support but I think thats better than the udevd eating too much CPU and flooding the logs.

I believe the correct fix is in the https://bugs.freedesktop.org/show_bug.cgi?id=23183 but it has been reverted from the kernel because of issues with some other (IMHO broken) hardware (https://bugs.freedesktop.org/show_bug.cgi?id=22785). The final fix would be to use current code with some selected BIOSes and the correct fix above for the rest. Unfortunately the correct fix requires non-trivial changes in the kernel and as such is not easy to backport, if I've understood correctly.