Comment 9 for bug 385477

Revision history for this message
kernel-janitor (kernel-janitor) wrote : Re: Compaq/HP Presario R4100 volume keys stick - kernel quirk

Hi jetdog,

Thanks for the report and writing a patch, that's awesome. Unfortunately the patch won't apply cleanly to the upcoming Karmic kernel - http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-karmic.git;a=summary . The kernel for Karmic is going to target the 2.6.31 kernel and it seems the driver has already changed since you patched it for 2.6.29.

Also, the Ubuntu kernel team policy typically requires that patches be submitted and accepted upstream first before pulling them into the Ubuntu kernel. Maintaining out of tree patches creates a lot of extra work for the team and is also generally frowned upon if the patch is acceptable for going upstream first. With that said, care to update the patch you have to be against the latest linux-input kernel tree and submit upstream? There should be plenty of time for this to get merged into 2.6.31 and then the Karmic kernel will get it automatically. I pulled the following information from the MAINTAINERS file which contains information for who and which mailing list the patch should be submitted to as well at the git tree which should be used for generating the patch. Thanks.

INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS
P: Dmitry Torokhov
M: <email address hidden>
M: <email address hidden>
L: <email address hidden>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
S: Maintained
F: drivers/input/