Ubuntu
linux package

  1. Bug #379780
  2. Comment #61

Comment 61 for bug 379780

Revision history for this message
In , Martin Pitt (pitti) wrote :

I was going to ask you about the two remaining DKD_PRESENTATION_NAME and DKD_PRESENTATION_ICON_NAME, since those caught my eye when doing the patch.

media-player-info does not use them, and I don't see anything else using them either:

$ grep -r DKD /lib/udev/rules.d
/lib/udev/rules.d/80-udisks.rules:ENV{DKD_PARTITION_SCHEME}=="apm", \
/lib/udev/rules.d/80-udisks.rules: ENV{DKD_PRESENTATION_HIDE}="1"

Should be a simple patch, let me know if you want me to just commit that.

As for ID_DRIVE_* I don't have a strong opinion. Right now they could potentially be moved into an udev helper. Renaming properties always bears the "breaks backwards compat" issue (for local site rules, anyway), and they have a reasonably generic naming scheme, so they didn't strike me as being urgent to rename.