Comment 15 for bug 2060919

Hi everyone,

As promised, I uploaded test kernels to the below ppa:

https://launchpad.net/~mruffell/+archive/ubuntu/lp2060919-test

They are based on 6.5.0-27-generic to keep it simple.

It just has "cifs: fix flushing folio regression for 6.1 backport". Thats it.
Pretty small patch:

commit 9dc02a5b7540d18a69bcbaf8f4fa428e32075b4b (HEAD -> lp2060919-test)
Author: Matthew Ruffell <email address hidden>
Date: Fri Apr 19 17:25:48 2024 +1200

    Revert "cifs: fix flushing folio regression for 6.1 backport"

    This reverts commit 21bb2ba4f1ac1e3a57594be62dd74e7b1401b2b1.

diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
index 55a6d0296ec8..82313b253463 100644
--- a/fs/smb/client/cifsfs.c
+++ b/fs/smb/client/cifsfs.c
@@ -1245,7 +1245,7 @@ static int cifs_flush_folio(struct inode *inode, loff_t pos, loff_t *_fstart, lo
        int rc = 0;

        folio = filemap_get_folio(inode->i_mapping, index);
- if (!folio)
+ if (IS_ERR(folio))
                return 0;

        size = folio_size(folio);

They are going to take about three hours to build, so check back later on. It's close to my EOD, and I can't watch these builds complete.

Please note this package is NOT SUPPORTED by Canonical, and is for TESTING
PURPOSES ONLY. ONLY Install in a dedicated test environment.

Instructions to Install (On a jammy or mantic system):
1) sudo add-apt-repository ppa:mruffell/lp2060919-test
2) sudo apt update
3) sudo apt install linux-image-unsigned-6.5.0-27-generic linux-modules-6.5.0-27-generic linux-modules-extra-6.5.0-27-generic linux-headers-6.5.0-27-generic
4) sudo reboot
5) uname -rv
6.5.0-27.28+TEST2060919v20240419b1
or
6.5.0-27.28~22.04.1+TEST2060919v20240419b1

Make sure the +TEST2060919v20240419b1 is present.

Can you let me know if it solves the problem?

Additionally, if you could help me create a reproducer that would help immensely.

Remember, they still need to build, check the ppa link to make sure it built successfully and is published before installing. About 3 hours from now.

Thanks,
Matthew