Comment 4 for bug 2004132

Revision history for this message
Matthew Ruffell (mruffell) wrote :

Performing verification for Focal

I started a fresh VM with 5.4.0-144-generic from -updates. I attached 2x virtio
disks of 3gb each, for scratch disks.

I ran btrfs/154 with the following results:

# ./check btrfs/154
FSTYP -- btrfs
PLATFORM -- Linux/x86_64 focal-xfs 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023
MKFS_OPTIONS -- /dev/vdd
MOUNT_OPTIONS -- /dev/vdd /scratch

btrfs/154 4s ... _check_dmesg: something found in dmesg (see /home/ubuntu/xfstests-dev/results//btrfs/154.dmesg)
- output mismatch (see /home/ubuntu/xfstests-dev/results//btrfs/154.out.bad)
    --- tests/btrfs/154.out 2023-01-28 07:54:34.007433164 +0000
    +++ /home/ubuntu/xfstests-dev/results//btrfs/154.out.bad 2023-03-14 04:34:53.765899711 +0000
    @@ -1,2 +1,6 @@
     QA output created by 154
    +Traceback (most recent call last):
    + File "/home/ubuntu/xfstests-dev/src/btrfs_crc32c_forged_name.py", line 99, in <module>
    + os.rename(srcpath, dstpath)
    +OSError: [Errno 75] Value too large for defined data type: '/scratch/309' -> b'/scratch/69f3?u\x97\xf3c33c58c648a2a9686fad82dbf43d7bfb443de4698f629e5b2b95126d6382430b8f29e4f502ccf306254d24cfd3800cb04a305989253db49f699a83cc2bc5d86a4f9b235891c0f72ba344a34e41aa69f819f196f7dbf29'
     Silence is golden
    ...
    (Run 'diff -u /home/ubuntu/xfstests-dev/tests/btrfs/154.out /home/ubuntu/xfstests-dev/results//btrfs/154.out.bad' to see the entire diff)
Ran: btrfs/154
Failures: btrfs/154
Failed 1 of 1 tests

[ 49.889518] BTRFS info (device vdc): flagging fs with big metadata feature
[ 49.889520] BTRFS info (device vdc): disk space caching is enabled
[ 49.889521] BTRFS info (device vdc): has skinny extents
[ 49.891250] BTRFS info (device vdc): checking UUID tree
[ 50.007425] BTRFS: device fsid 382d436d-5f41-48a3-b96d-42c07ede9a03 devid 1 transid 5 /dev/vdd
[ 50.012807] BTRFS info (device vdd): flagging fs with big metadata feature
[ 50.012809] BTRFS info (device vdd): disk space caching is enabled
[ 50.012810] BTRFS info (device vdd): has skinny extents
[ 50.014307] BTRFS info (device vdd): checking UUID tree
[ 50.171099] BTRFS info (device vdc): flagging fs with big metadata feature
[ 50.171102] BTRFS info (device vdc): disk space caching is enabled
[ 50.171103] BTRFS info (device vdc): has skinny extents
[ 50.204928] run fstests btrfs/154 at 2023-03-14 04:34:47
[ 50.378091] BTRFS: device fsid 68eee97a-92e0-47da-9d5e-c6c8312ee358 devid 1 transid 5 /dev/vdd
[ 50.393188] BTRFS info (device vdd): flagging fs with big metadata feature
[ 50.393191] BTRFS info (device vdd): disk space caching is enabled
[ 50.393193] BTRFS info (device vdd): has skinny extents
[ 50.401657] BTRFS info (device vdd): checking UUID tree
[ 56.084117] ------------[ cut here ]------------
[ 56.084121] BTRFS: Transaction aborted (error -75)
[ 56.084229] WARNING: CPU: 2 PID: 1741 at fs/btrfs/inode.c:10148 btrfs_rename+0x9c6/0xa40 [btrfs]
[ 56.084265] CPU: 2 PID: 1741 Comm: python3 Not tainted 5.4.0-144-generic #161-Ubuntu
[ 56.084267] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.0-debian-1.16.0-4 04/01/2014
[ 56.084302] RIP: 0010:btrfs_rename+0x9c6/0xa40 [btrfs]
[ 56.084306] Code: 48 0f ba a8 38 ce 00 00 02 72 25 41 83 f8 fb 74 43 41 83 f8 e2 74 3d 44 89 c6 48 c7 c7 e0 68 49 c0 44 89 45 a0 e8 ac 2c 0a e6 <0f> 0b 44 8b 45 a0 44 89 c1 ba a4 27 00 00 4c 89 f7 44 89 45 a0 48
[ 56.084309] RSP: 0018:ffffbb1182f17cd8 EFLAGS: 00010286
[ 56.084311] RAX: 0000000000000000 RBX: ffff9ca8b7114210 RCX: 0000000000000006
[ 56.084313] RDX: 0000000000000007 RSI: 0000000000000086 RDI: ffff9ca8bbb1c8c0
[ 56.084314] RBP: ffffbb1182f17d70 R08: 000000000000032b R09: 0000000000000004
[ 56.084315] R10: 0000000000000000 R11: 0000000000000001 R12: ffff9ca8b7104b40
[ 56.084317] R13: ffff9ca8b726a220 R14: ffff9ca8b7b03548 R15: 0000000000000236
[ 56.084320] FS: 00007f3e9e8be740(0000) GS:ffff9ca8bbb00000(0000) knlGS:0000000000000000
[ 56.084321] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 56.084323] CR2: 00007fb85fbc5110 CR3: 000000016c17e004 CR4: 0000000000760ee0
[ 56.084331] PKRU: 55555554
[ 56.084333] Call Trace:
[ 56.084364] btrfs_rename2+0x1d/0x30 [btrfs]
[ 56.084371] vfs_rename+0x3df/0x9b0
[ 56.084377] ? _cond_resched+0x19/0x30
[ 56.084383] ? security_path_rename+0x88/0xb0
[ 56.084387] do_renameat2+0x507/0x570
[ 56.084391] __x64_sys_rename+0x23/0x30
[ 56.084397] do_syscall_64+0x57/0x190
[ 56.084401] entry_SYSCALL_64_after_hwframe+0x5c/0xc1
[ 56.084403] RIP: 0033:0x7f3e9eaece8b
[ 56.084406] Code: e8 ca ce 0a 00 85 c0 0f 95 c0 0f b6 c0 f7 d8 5d c3 66 0f 1f 44 00 00 b8 ff ff ff ff 5d c3 90 f3 0f 1e fa b8 52 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 05 c3 0f 1f 40 00 48 8b 15 d1 8f 18 00 f7 d8
[ 56.084408] RSP: 002b:00007ffddfe043f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
[ 56.084410] RAX: ffffffffffffffda RBX: 00007ffddfe044c0 RCX: 00007f3e9eaece8b
[ 56.084412] RDX: 0000000000000000 RSI: 00007f3e9e5584b0 RDI: 00007f3e9e676770
[ 56.084413] RBP: 00007ffddfe04470 R08: 0000000000000000 R09: 00000000ffffffff
[ 56.084414] R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffff9c
[ 56.084416] R13: 00000000ffffff9c R14: 00000000018c85c0 R15: 000000009e7c6700
[ 56.084419] ---[ end trace 800525b1e4cacc35 ]---
[ 56.084424] BTRFS: error (device vdd) in btrfs_rename:10148: errno=-75 unknown
[ 56.086071] BTRFS info (device vdd): forced readonly
[ 56.339439] BTRFS info (device vdd): flagging fs with big metadata feature
[ 56.339442] BTRFS info (device vdd): disk space caching is enabled
[ 56.339443] BTRFS info (device vdd): has skinny extents
[ 56.347861] BTRFS warning (device vdd): block group 30408704 has wrong amount of free space
[ 56.347862] BTRFS warning (device vdd): failed to load free space cache for block group 30408704, rebuilding it now

The test fails on the kernel in -updates, as expected.

I then enabled -proposed, and installed 5.4.0-145-generic.

Re-running the test on a clean btrfs filesystem:

# ./check btrfs/154
FSTYP -- btrfs
PLATFORM -- Linux/x86_64 focal-xfs 5.4.0-145-generic #162-Ubuntu SMP Fri Feb 24 13:43:15 UTC 2023
MKFS_OPTIONS -- /dev/vdd
MOUNT_OPTIONS -- /dev/vdd /scratch

btrfs/154 4s ... 4s
Ran: btrfs/154
Passed all 1 tests

The test passes and there is no output in dmesg. The kernel in -proposed fixes the issue and I am happy to mark it as verified for Focal.