Comment 6 for bug 1934414

Revision history for this message
Thadeu Lima de Souza Cascardo (cascardo) wrote :

Backporting everything necessary would be up to many potential regressions. That would include support for BPF calls and the change to make unknown opcode handling more robust.

The former would be commit cc8b0b92a1699bc32f7fec71daa2bfc90de43a4d "bpf: introduce function calls (function boundaries)", which would open a big can of worms we don't want to do.

The latter is commit 5e581dad4fec0e6d062740dc35b8dc248b39d224 "bpf: make unknown opcode handling more robust". Though it might add more robustness, it changes the table in the interpreter, so I decided not to backport it now, and fixup the error messages in test_verifier, instead.

By the way, commit 21ccaf21497b72f42133182716a42dbf573d314b "bpf: add further test cases around div/mod and others" should have been 3, at least 2, different commits. As it only changes tests, I am find simply doing a partial backport of it.

I have it ready and tested, will send a patchset to the list.

Cascardo.