Comment 29 for bug 1894017

Revision history for this message
Hans de Goede (j-w-r-degoede) wrote :

@kaihengfeng, can you perhaps build a 5.9.xx kernel with:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d823346876a970522ff9e4d2b323c9b734dcc4de added for @dacto from comment 25 to test ?

His device gets intel-vbtn SW_TABLET_MODE support enabled based on the chassis-type, yet it seems to always report SW_TABLET_MODE=1, I want to know if the mentioned commit fixes this. This commit was a workaround introduced before we switched to an allow list (which includes certain chassis-types). This workaround was reverted after switching to the allow list, but since @dacto is still seeing this with 5.9.10 it looks like we may need the workaround even with the new allow-list approach.

@dacto, 2 questions:

1. What happens with 5.9.10 if you fold the 2-in-1 into tablet mode and then back into laptop/clamshell mode again, does that fix the kbd and touchpad not working ?

2. Can you provide an acpidump of your device? Run:

sudo acpidump -o acpidump.HP-Convertible-x360-11-ab0XX

And then attach the generated acpidump.HP-Convertible-x360-11-ab0XX file here, or send it directly to me: <email address hidden> .

###

So looking closer at the difference between 5.4.75 and 5.9.10, 5.9.10 has:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=21d64817c72470ed69483f59279ce557c0658826

Which 5.4.75 does not have, so this strongly suggests that despite switching to the allow list we still need the workaround for some HP models and it should be re-added (undoing the revert / undoing the dropping of the workaround).

I can take care of getting this re-added but first I would like to see some confirmation that this is indeed the problem.

Ideally you (@dacto) would test a 5.9.10 (or .11 or .12) kernel with the patch added, but I can also confirm that this patch needs to be re-added by looking at an acpidump.