Comment 3 for bug 1831566

Revision history for this message
Sultan Alsawaf (kerneltoast) wrote :

It looks like the supplied patch is a no-op. A module parameter is introduced with a .set function, but the parameter does not have any write permission specified so the .set function can never execute (since userspace won't have permission to write to the module parameter file).

module_param_cb(cq_cpulist, &cq_cpulist_ops, NULL, 0);
                                                 ~~^~

This 0 provided to module_param_cb() is the octal UNIX permissions argument to module_param_cb(). The correct value should be 0200 in this case, to specify write-only permission.