Ubuntu
linux package

  1. Bug #1830587
  2. Comment #0

Comment 0 for bug 1830587

Revision history for this message
Ike Panhc (ikepanhc) wrote :

We have a warning[1] in dmesg shows hns register napi as weight 256 but not recommended. According to this commit[2] we shall use weight 64 as suggested.

To cherry-pick this makes hns driver has reasonable weight

commit acb1ce15a61154aa501891d67ebf79bc9ea26818
Author: Yonglong Liu <email address hidden>
Date: Thu Apr 4 16:46:43 2019 +0800

    net: hns: Use NAPI_POLL_WEIGHT for hns driver

    When the HNS driver loaded, always have an error print:
    "netif_napi_add() called with weight 256"

    This is because the kernel checks the NAPI polling weights
    requested by drivers and it prints an error message if a driver
    requests a weight bigger than 64.

    So use NAPI_POLL_WEIGHT to fix it.

    Signed-off-by: Yonglong Liu <email address hidden>
    Signed-off-by: Peng Li <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>

[1] netif_napi_add() called with weight 256
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82dc3c63c692b1e1d59378ecee948ac88e034aad