Comment 21 for bug 1811785

The kernel issue pointed at the github was solved by:

commit cbaee3aa0e23
Author: Dan Williams <email address hidden>
Date: Thu Feb 7 20:56:50 2019

    acpi/nfit: Fix bus command validation

    BugLink: https://bugs.launchpad.net/bugs/1821607

in kernel: Ubuntu-5.0.0-9.10 (Disco)

AND

commit 3b8d3410b3d8
Author: Dan Williams <email address hidden>
Date: Thu Feb 7 20:56:50 2019

    acpi/nfit: Fix bus command validation

    BugLink: https://bugs.launchpad.net/bugs/1837952

    commit ebe9f6f19d80d8978d16078dff3d5bd93ad8d102 upstream.

in kernel: Ubuntu-4.15.0-59.66 (Bionic)

So kernel part is good.... (or kind of.. actually it is missing 2 fixes on top of that):

----

TODO: KERNEL TEAM SHOULD BACKPORT THIS TO BIONIC AND DISCO:

commit ebe9f6f19d80
Author: Dan Williams <email address hidden>
Date: Thu Feb 7 20:56:50 2019

    acpi/nfit: Fix bus command validation

    Fixes: 11189c1089da ("acpi/nfit: Fix command-supported detection")

commit 0171b6b78131
Author: Dan Williams <email address hidden>
Date: Sun Feb 3 17:17:27 2019

    acpi/nfit: Require opt-in for read-only label configurations

    Fixes: 11189c1089da ("acpi/nfit: Fix command-supported detection")

TO FIX THE ISSUE'S FIX

-----

TODO: FEEDBACK ABOUT PROPOSED USERLAND FIX

and the userland fix was, indeed, the ndctl patch I did a SRU for.

UNFORTUNATELY I can't reproduce the issue with QEMU. I have tried different label sizes in multiple attempts and wasn't able to cause the labeling error (making sure it was fixed). With that it is hard for me to guarantee the fix is good and I'll depend on a feedback from reporter.

There is a PPA in comment #19 containing the fix. I'll flag this case as incomplete while I have no feedback, as we wouldn't be able to verify the fix in order for it to land -updates archive.

Nevertheless, documentation here might be important to others, in order to understand the errors.