Samsung SSD 750/850/860/870 EVO/QVO doesn't support queued TRIM command

[Victor Belyaevski]

SSD drive stops processing requests after a while
With attached patch system is stable.
Exact SSD information:
---
Model=Samsung SSD 750 EVO 250GB, FwRev=MAT01B6Q, SerialNo=S33SNWBH536151Z
---

Please note that system uses different SSD during bug reporting.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: linux-image-4.15.0-43-generic 4.15.0-43.46
ProcVersionSignature: Ubuntu 4.15.0-43.46-generic 4.15.18
Uname: Linux 4.15.0-43-generic x86_64
ApportVersion: 2.20.9-0ubuntu7.5
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/pcmC1D0p: victor 2307 F...m pulseaudio
 /dev/snd/controlC1: victor 2307 F.... pulseaudio
 /dev/snd/controlC0: victor 2307 F.... pulseaudio
CurrentDesktop: KDE
Date: Fri Dec 28 15:25:43 2018
HibernationDevice: RESUME=/dev/kubuntu-vg/swap_1
MachineType: LENOVO 20BV0064US
ProcFB: 0 inteldrmfb
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-4.15.0-43-generic root=/dev/mapper/kubuntu--vg-root ro resume=/dev/kubuntu-vg/swap_1 quiet splash
RelatedPackageVersions:
 linux-restricted-modules-4.15.0-43-generic N/A
 linux-backports-modules-4.15.0-43-generic N/A
 linux-firmware 1.173.2
SourcePackage: linux
UpgradeStatus: Upgraded to bionic on 2018-06-11 (200 days ago)
dmi.bios.date: 07/13/2016
dmi.bios.vendor: LENOVO
dmi.bios.version: JBET61WW (1.25 )
dmi.board.asset.tag: Not Available
dmi.board.name: 20BV0064US
dmi.board.vendor: LENOVO
dmi.board.version: SDK0J40705 WIN
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: None
dmi.modalias: dmi:bvnLENOVO:bvrJBET61WW(1.25):bd07/13/2016:svnLENOVO:pn20BV0064US:pvrThinkPadT450:rvnLENOVO:rn20BV0064US:rvrSDK0J40705WIN:cvnLENOVO:ct10:cvrNone:
dmi.product.family: ThinkPad T450
dmi.product.name: 20BV0064US
dmi.product.version: ThinkPad T450
dmi.sys.vendor: LENOVO

[Victor Belyaevski (victor012)]

Please note that system uses different SSD during bug reporting.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This change was made by a bot.

[Kai-Heng Feng (kaihengfeng)]

Thanks for the patch.

Please send the patch upstream so we can back port the patch to Ubuntu's kernel, thanks!

[Victor Belyaevski (victor012)]

https://bugzilla.kernel.org/show_bug.cgi?id=202093

[Gregory P Smith (gpshead)]

This also happens on the brand new Samsung 870 EVO.

And based on https://bugzilla.kernel.org/show_bug.cgi?id=203475 and https://bugzilla.kernel.org/show_bug.cgi?id=201693 a variety of other Samsung 8* devices on a wide variety of SATA controllers (it doesn't seem controller related).

At the very least, the upstream change https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ca6bfcb2f6d9deab3924bf901e73622a94900473 is wrong and really needs to be rolled back... And adjusted further given this issue was filed for a 750 which that change didn't even cover.

The patch attached to this issue does exactly that.

Distros should patch that change out in their kernels.

[Gregory P Smith (gpshead)]

I'm seeing this with my 870 EVO on 20.04 kernel 5.4.0-65-generic.