Comment 0 for bug 1799794

Revision history for this message
Manoj Iyer (manjo) wrote :

[Impact]
Unable to send ipmi raw command greater than 255bytes, eg hostnames. Multipart transmit messages with ipmi currently fails.

[Fix]
commit 10042504ed92c06077b8a20a4edd67ba784847d4
Author: Corey Minyard <email address hidden>
Date: Fri Jul 27 07:36:20 2018 -0500

    ipmi:ssif: Add support for multi-part transmit messages > 2 parts

[Test]
-- before applying patch --
Running Get PICMG Properties my_addr 0x20, transit 0, target 0
Error response 0xc1 from Get PICMG Properities
Running Get VSO Capabilities my_addr 0x20, transit 0, target 0
Invalid completion code received: Invalid command
Discovered IPMB address 0x0
RAW REQ (channel=0x0 netfn=0x32 lun=0x0 cmd=0x6c data_len=132)
RAW REQUEST (132 bytes)
 01 00 00 0d 42 4d 43 41 52 36 34 5a 41 4c 4f 4e
 35 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00
Unable to send RAW command (channel=0x0 netfn=0x32 lun=0x0 cmd=0x6c rsp=0xff): Unspecified error

-- After applying the patch --
Running Get PICMG Properties my_addr 0x20, transit 0, target 0
Error response 0xc1 from Get PICMG Properities
Running Get VSO Capabilities my_addr 0x20, transit 0, target 0
Invalid completion code received: Invalid command
Discovered IPMB address 0x0
RAW REQ (channel=0x0 netfn=0x32 lun=0x0 cmd=0x6c data_len=132)
RAW REQUEST (132 bytes)
 01 00 00 0d 42 4d 43 41 52 36 34 5a 41 4c 4f 4e
 35 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00
RAW RSP (0 bytes)

[Regression Potential]
The patch to ipmi_ssif module cleanly cherry-picks from linux-next, the patch touches no platform code. The kernel was tested on a Cavium Thunder X2 system and no regressions were found.