Comment 0 for bug 1782166

Impact:

The snapcraft.yaml in bionic/master still invokes the obsolete 'firmware_install' target that was removed in 5620a0d1aacd554ebebcff373e31107bb1ef7769 ("firmware: delete in-kernel firmware"), and by invoking a non existin target, snap build fails.

On a generic amd64 environment, check out the Bionic/generic tree, cd into it and execute snapcraft:

linux $ snapcraft
...
make -j4 bzImage modules
...
  LD [M] virt/lib/irqbypass.ko
make: *** No rule to make target 'firmware_install'. Stop.
make: *** Waiting for unfinished jobs....
  INSTALL arch/x86/crypto/blowfish-x86_64.ko
...
make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware
Failed to run 'make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware' for 'kernel': Exited with code 2.
Verify that the part is using the correct parameters and try again.

Fix:

Stop invoking a non existing target by applying the attached patch.

$ snapcraft
...

Regression risk:

None since the patch only modifies the snapcraft.yaml file.