Comment 4 for bug 1720229

Revision history for this message
dann frazier (dannf) wrote :

This can be easily reproduced on a running VM with the command:

sudo dmraid -r -c

Bisection shows that this regression was introduced with:

ca18d6f769d22e931d3ba1e8d1ae81953547a417 is the first bad commit
commit ca18d6f769d22e931d3ba1e8d1ae81953547a417
Author: Bart Van Assche <email address hidden>
Date: Tue Jun 20 11:15:41 2017 -0700

    block: Make most scsi_req_init() calls implicit

    Instead of explicitly calling scsi_req_init() after blk_get_request(),
    call that function from inside blk_get_request(). Add an
    .initialize_rq_fn() callback function to the block drivers that need
    it. Merge the IDE .init_rq_fn() function into .initialize_rq_fn()
    because it is too small to keep it as a separate function. Keep the
    scsi_req_init() call in ide_prep_sense() because it follows a
    blk_rq_init() call.

    References: commit 82ed4db499b8 ("block: split scsi_request out of struct request")
    Signed-off-by: Bart Van Assche <email address hidden>
    Cc: Christoph Hellwig <email address hidden>
    Cc: Hannes Reinecke <email address hidden>
    Cc: Omar Sandoval <email address hidden>
    Cc: Nicholas Bellinger <email address hidden>
    Signed-off-by: Jens Axboe <email address hidden>

:040000 040000 ee31876ef709a9f8cd4f22cf5f7856b33551fce7 d0bee2b06aad3ee1f98636692c410faa950b4421 M block
:040000 040000 87c490a081c83a4c5a4566805275d43560675254 40ecea9fd8c35cb11e4cd20a12fef32bf99e4a0f M drivers
:040000 040000 cc72534f639a3c4f55dc4b5d01e487ee4e59e7aa 95b6dcb4afcae8d2a6024123de8a95cfd1c3ede1 M fs
:040000 040000 27071201e8723e9f873e45886bd7f370b39bcb5c c6ab8cd38a8d2d7dffd915b931fdb4ff3b7880d1 M include