thunderx nic performance improvements

Bug #1567093 reported by dann frazier on 2016-04-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Medium
dann frazier
Xenial
Medium
dann frazier

Bug Description

Two patches have landed upstream that improve thunderx nic performance:

commit b6e4038262bc933f2ef5427b6bcd2607d02ba4bb
Merge: 9bd160b 1d36879
Author: David S. Miller <email address hidden>
Date: Mon Mar 14 12:33:37 2016 -0400

    Merge branch 'thunderx-perf'

    Sunil Goutham says:

    ====================
    net: thunderx: Performance enhancement changes

    Below patches attempts to improve performance by reducing
    no of atomic operations while allocating new receive buffers
    and reducing cache misses by adjusting nicvf structure elements.

    Changes from v1:
     No changes, resubmitting a fresh as per David's suggestion.
    ====================

    Signed-off-by: David S. Miller <email address hidden>

commit 1d368790bc2d4111feae6fcc0b3b68d6ae92ff0f
Author: Sunil Goutham <email address hidden>
Date: Mon Mar 14 16:36:15 2016 +0530

    net: thunderx: Adjust nicvf structure to reduce cache misses

    Adjusted nicvf structure such that all elements used in hot
    path like napi, xmit e.t.c fall into same cache line. This reduced
    no of cache misses and resulted in ~2% increase in no of packets
    handled on a core.

    Also modified elements with :1 notation to boolean, to be
    consistent with other element definitions.

    Signed-off-by: Sunil Goutham <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>

commit 5c2e26f6f674ee93719769d024cc72fad3ba9134
Author: Sunil Goutham <email address hidden>
Date: Mon Mar 14 16:36:14 2016 +0530

    net: thunderx: Set recevie buffer page usage count in bulk

    Instead of calling get_page() for every receive buffer carved out
    of page, set page's usage count at the end, to reduce no of atomic
    calls.

    Signed-off-by: Sunil Goutham <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>

CVE References

Tim Gardner (timg-tpi) on 2016-04-07
Changed in linux (Ubuntu Xenial):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :
Download full text (3.5 KiB)

This bug was fixed in the package linux - 4.4.0-21.37

---------------
linux (4.4.0-21.37) xenial; urgency=low

  [ Tim Gardner ]

  * Release Tracking Bug
    - LP: #1571791

  * linux: MokSBState is ignored (LP: #1571691)
    - SAUCE: (noup) MODSIGN: Import certificates from UEFI Secure Boot
    - SAUCE: (noup) efi: Disable secure boot if shim is in insecure mode
    - SAUCE: (noup) Display MOKSBState when disabled

linux (4.4.0-20.36) xenial; urgency=low

  [ Tim Gardner ]

  * Release Tracking Bug
    - LP: #1571069

  * sysfs mount failure during stateful lxd snapshots (LP: #1570906)
    - SAUCE: kernfs: Do not match superblock in another user namespace when
      mounting

  * Kernel Panic in Ubuntu 16.04 netboot installer (LP: #1570441)
    - x86/topology: Fix logical package mapping
    - x86/topology: Fix Intel HT disable
    - x86/topology: Use total_cpus not nr_cpu_ids for logical packages
    - xen/apic: Provide Xen-specific version of cpu_present_to_apicid APIC op
    - x86/topology: Fix AMD core count

  * [regression]: Failed to call clock_adjtime(): Invalid argument
    (LP: #1566465)
    - ntp: Fix ADJ_SETOFFSET being used w/ ADJ_NANO

linux (4.4.0-19.35) xenial; urgency=low

  [ Tim Gardner ]

  * Release Tracking Bug
    - LP: #1570348

  * CVE-2016-2847 (LP: #1554260)
    - pipe: limit the per-user amount of pages allocated in pipes

  * xenial kernel crash on HP BL460c G7 (qla24xx problem?) (LP: #1554003)
    - SAUCE: (noup) qla2xxx: Add irq affinity notification V2

  * arm64: guest hangs when ntpd is running (LP: #1549494)
    - SAUCE: (noup) KVM: arm/arm64: Handle forward time correction gracefully

  * linux: Enforce signed module loading when UEFI secure boot (LP: #1566221)
    - [Config] CONFIG_EFI_SECURE_BOOT_SIG_ENFORCE=y

  * s390/cpumf: Fix lpp detection (LP: #1555344)
    - s390/facilities: use stfl mnemonic instead of insn magic
    - s390/facilities: always use lowcore's stfle field for storing facility bits
    - s390/cpumf: Fix lpp detection

  * s390x kernel image needs weightwatchers (LP: #1536245)
    - [Config] s390x: Use compressed kernel bzImage

  * Surelock GA2 SP1: surelock02p05: Not seeing sgX devices for LUNs after
    upgrading to Ubuntu 16.04 (LP: #1567581)
    - Revert "UBUNTU: SAUCE: (noup) powerpc/pci: Assign fixed PHB number based on
      device-tree properties"

  * Backport upstream bugfixes to ubuntu-16.04 (LP: #1555765)
    - cpufreq: powernv: Define per_cpu chip pointer to optimize hot-path
    - Revert "cpufreq: postfix policy directory with the first CPU in related_cpus"
    - cpufreq: powernv: Add sysfs attributes to show throttle stats

  * systemd-modules-load.service: Failing due to missing module 'ib_iser' (LP: #1566468)
    - [Config] Add ib_iser to generic inclusion list

  * thunderx nic performance improvements (LP: #1567093)
    - net: thunderx: Set recevie buffer page usage count in bulk
    - net: thunderx: Adjust nicvf structure to reduce cache misses

  * fixes for thunderx nic in multiqueue mode (LP: #1567091)
    - net: thunderx: Fix for multiqset not configured upon interface toggle
    - net: thunderx: Fix for HW TSO not enabled for secondary qsets
    - net: thund...

Read more...

Changed in linux (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers