Comment 9 for bug 1482273

Revision history for this message
Mark Standridge (mrstandridge) wrote :

I think I've found the bad commit that introduced this bug, dc487e5b0e9e401e9705dc4c62b9170711c68f77 thermal: step_wise: Revert optimization. I have extensively tested kernels 3.13.0-63 and 3.13.0-64 after this commit is reverted and they boot without issue and run without crashing. Reverting this will expose a bug in the acerhdf fan module preventing fan control on some old netbooks.

diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c
index d89e781..769bfa3 100644
--- a/drivers/thermal/step_wise.c
+++ b/drivers/thermal/step_wise.c
@@ -140,9 +140,6 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
        old_target = instance->target;
        instance->target = get_target_state(instance, trend, throttle);

- if (old_target == instance->target)
- continue;
-
        /* Activate a passive thermal instance */
        if (old_target == THERMAL_NO_TARGET &&
            instance->target != THERMAL_NO_TARGET)

I have attached the git bisect log.

I am unable to update the BIOS at this time. Updating with the built in GSet BIOS Flash Updater fails with "Dell ID is not matched." and attempting to update under FreeDOS hangs the machine with no error message.