rfkill unable to control HP 2510p wireless devices

[Gleb Kozyrev]

With recent kernels (3.13 in trusty beta and 3.11 on precise) I can't turn on/off some hp-specific wireless devices (bluetooth, wwan) with rfkill and GUI tools.
This seems to be a regression in hp_wmi.

Correct behavior:
On 3.11.0-15-generic #25~precise1-Ubuntu
> rfkil llist
 0: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: yes
1: hp-wifi: Wireless LAN
        Soft blocked: yes
        Hard blocked: no
2: hp-bluetooth: Bluetooth
        Soft blocked: yes
        Hard blocked: no
3: hp-wwan: Wireless WAN
        Soft blocked: yes
        Hard blocked: no
4: hp-gps: GPS
        Soft blocked: yes
        Hard blocked: yes

Incorrect behavior:
On 3.11.0-18-generic #32~precise1-Ubuntu and 3.13.0-16-generic #36-Ubuntu
> rfkill list
0: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: no

Relevant upstream bug: https://bugzilla.kernel.org/show_bug.cgi?id=69131

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: linux-image-3.13.0-16-generic 3.13.0-16.36
ProcVersionSignature: Ubuntu 3.13.0-16.36-generic 3.13.5
Uname: Linux 3.13.0-16-generic x86_64
ApportVersion: 2.13.3-0ubuntu1
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: gleb 2472 F.... pulseaudio
CurrentDesktop: XFCE
CurrentDmesg: Error: command ['sh', '-c', 'dmesg | comm -13 --nocheck-order /var/log/dmesg -'] failed with exit code 1: comm: /var/log/dmesg: Permission denied
Date: Mon Mar 10 17:23:18 2014
InstallationDate: Installed on 2014-02-18 (20 days ago)
InstallationMedia: Xubuntu 14.04 LTS "Trusty Tahr" - Alpha amd64 (20140216)
MachineType: Hewlett-Packard HP Compaq 2510p Notebook PC
PccardctlIdent:
 Socket 0:
   no product info available
PccardctlStatus:
 Socket 0:
   no card
ProcFB: 0 inteldrmfb
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-3.13.0-16-generic root=UUID=b8a1cc3a-672f-423b-9550-d804244bfb59 ro quiet splash vt.handoff=7
RfKill:
 0: phy0: Wireless LAN
  Soft blocked: no
  Hard blocked: no
SourcePackage: linux
UpgradeStatus: No upgrade log present (probably fresh install)
WifiSyslog:

dmi.bios.date: 04/22/2011
dmi.bios.vendor: Hewlett-Packard
dmi.bios.version: 68MSP Ver. F.10
dmi.board.name: 30C9
dmi.board.vendor: Hewlett-Packard
dmi.board.version: KBC Version 75.28
dmi.chassis.type: 10
dmi.chassis.vendor: Hewlett-Packard
dmi.modalias: dmi:bvnHewlett-Packard:bvr68MSPVer.F.10:bd04/22/2011:svnHewlett-Packard:pnHPCompaq2510pNotebookPC:pvrF.10:rvnHewlett-Packard:rn30C9:rvrKBCVersion75.28:cvnHewlett-Packard:ct10:cvr:
dmi.product.name: HP Compaq 2510p Notebook PC
dmi.product.version: F.10
dmi.sys.vendor: Hewlett-Packard
---
ApportVersion: 2.13.3-0ubuntu1
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: gleb 2472 F.... pulseaudio
CurrentDesktop: XFCE
CurrentDmesg:
 Error: command ['sh', '-c', 'dmesg | comm -13 --nocheck-order /var/log/dmesg -'] failed with exit code 1: comm: /var/log/dmesg: Permission denied
 dmesg: write failed: Broken pipe
DistroRelease: Ubuntu 14.04
InstallationDate: Installed on 2014-02-18 (20 days ago)
InstallationMedia: Xubuntu 14.04 LTS "Trusty Tahr" - Alpha amd64 (20140216)
MachineType: Hewlett-Packard HP Compaq 2510p Notebook PC
Package: linux (not installed)
PccardctlIdent:
 Socket 0:
   no product info available
PccardctlStatus:
 Socket 0:
   no card
ProcFB: 0 inteldrmfb
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-3.13.0-16-generic root=UUID=b8a1cc3a-672f-423b-9550-d804244bfb59 ro quiet splash vt.handoff=7
ProcVersionSignature: Ubuntu 3.13.0-16.36-generic 3.13.5
RfKill:
 0: phy0: Wireless LAN
  Soft blocked: no
  Hard blocked: no
Tags: trusty
Uname: Linux 3.13.0-16-generic x86_64
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: audio ff sudo
WifiSyslog:

_MarkForUpload: True
dmi.bios.date: 04/22/2011
dmi.bios.vendor: Hewlett-Packard
dmi.bios.version: 68MSP Ver. F.10
dmi.board.name: 30C9
dmi.board.vendor: Hewlett-Packard
dmi.board.version: KBC Version 75.28
dmi.chassis.type: 10
dmi.chassis.vendor: Hewlett-Packard
dmi.modalias: dmi:bvnHewlett-Packard:bvr68MSPVer.F.10:bd04/22/2011:svnHewlett-Packard:pnHPCompaq2510pNotebookPC:pvrF.10:rvnHewlett-Packard:rn30C9:rvrKBCVersion75.28:cvnHewlett-Packard:ct10:cvr:
dmi.product.name: HP Compaq 2510p Notebook PC
dmi.product.version: F.10
dmi.sys.vendor: Hewlett-Packard

[adi (adi-linux-kernel-bugs)]

Hi!

As of 3.13, the wifi card on my HP nx6325 remains hard-blocked no matter how much I press the hardware button or run rfkill:

Oddly enough, it reports hard-blocked after trying to set the interface up.

Transcript:

chopin:~# rfkill list
2: phy2: Wireless LAN
        Soft blocked: no
        Hard blocked: yes
chopin:~# rmmod b43
chopin:~# modprobe b43
chopin:~# rfkill list
3: phy3: Wireless LAN
        Soft blocked: no
        Hard blocked: no
chopin:~# ifconfig wlan0 up
chopin:~# iwlist wlan0 scan
wlan0 Interface doesn't support scanning : Network is down

chopin:~# rfkill list
3: phy3: Wireless LAN
        Soft blocked: no
        Hard blocked: yes
--- end of transcript ---

The LED remains off all the time, it only flashes once when running "ifconfig wlan0 up", but the device isn't really up.

Needless to say it's impossible to connect via wifi, hence the raised priority.

For the sake of completeness, let me add that 3.12.8 isn't affected, so it's clearly a regression.

[mjg59-kernel (mjg59-kernel-linux-kernel-bugs)]

Does rfkill list show an hp-wmi entry on 3.12?

[adi (adi-linux-kernel-bugs)]

Yes, it does:

chopin:~# uname -a
Linux chopin 3.12.8 #2 SMP PREEMPT Tue Jan 21 13:42:16 CET 2014 x86_64 GNU/Linux
chopin:~# rfkill list
0: hp-wifi: Wireless LAN
        Soft blocked: yes
        Hard blocked: yes
1: hp-bluetooth: Bluetooth
        Soft blocked: yes
        Hard blocked: yes
2: hp-gps: GPS
        Soft blocked: yes
        Hard blocked: yes
3: phy0: Wireless LAN
        Soft blocked: yes
        Hard blocked: no

[mjg59-kernel (mjg59-kernel-linux-kernel-bugs)]

Can you try reverting 997daa1bd9aca412ab97955a35b26c460c0ec7a4 and see if that helps?

[adi (adi-linux-kernel-bugs)]

This really helps. With 997daa1bd9aca412ab97955a35b26c460c0ec7a4 reverted, it works again:

chopin:~# uname -a
Linux chopin 3.13.0 #2 SMP PREEMPT Tue Jan 21 14:51:15 CET 2014 x86_64 GNU/Linux
chopin:~# rfkill list
0: hp-wifi: Wireless LAN
        Soft blocked: no
        Hard blocked: no
1: hp-bluetooth: Bluetooth
        Soft blocked: yes
        Hard blocked: no
2: hp-gps: GPS
        Soft blocked: yes
        Hard blocked: yes
3: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: no

I took the liberty to attach the acpidump output of the machine in question, just in case you need to have a look at the WMI section.

[adi (adi-linux-kernel-bugs)]

Created attachment 122891
acpidump output

[mjg59-kernel (mjg59-kernel-linux-kernel-bugs)]

Created attachment 122901
Test patch

Ok. Can you reapply that commit and then test this patch?

[adi (adi-linux-kernel-bugs)]

Your patch works like a charm:

chopin:~# uname -a
Linux chopin 3.13.0 #3 SMP PREEMPT Tue Jan 21 16:06:03 CET 2014 x86_64 GNU/Linux
chopin:~# rfkill list
0: hp-wifi: Wireless LAN
        Soft blocked: no
        Hard blocked: no
1: hp-bluetooth: Bluetooth
        Soft blocked: yes
        Hard blocked: no
2: hp-gps: GPS
        Soft blocked: yes
        Hard blocked: yes
3: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: no

JFTR, hp_wmi_bios_2009_later is unused for now:

drivers/platform/x86/hp-wmi.c:296:12: warning: ‘hp_wmi_bios_2009_later’ defined but not used [-Wunused-function]
 static int hp_wmi_bios_2009_later(void)

[mjg59-kernel (mjg59-kernel-linux-kernel-bugs)]

Thanks, I'll follow up with Alex and figure out the best plan here.

[Brad Figg (brad-figg)]

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1290418

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Gleb Kozyrev (gkozyrev)]

apport information

[Joseph Salisbury (jsalisbury)]

Would it be possible for you to test the latest upstream kernel? Refer to https://wiki.ubuntu.com/KernelMainlineBuilds . Please test the latest v3.13 kernel[0].

If this bug is fixed in the mainline kernel, please add the following tag 'kernel-fixed-upstream'.

If the mainline kernel does not fix this bug, please add the tag: 'kernel-bug-exists-upstream'.

If you are unable to test the mainline kernel, for example it will not boot, please add the tag: 'kernel-unable-to-test-upstream'.
Once testing of the upstream kernel is complete, please mark this bug as "Confirmed".

Thanks in advance.

[0] http://kernel.ubuntu.com/~kernel-ppa/mainline/v3.14-rc6-trusty/

[Tim Davis (cpuobsessed)]

HP Compaq 6910p, same behaviour
Tried the latest kernel 3.14-rc6-trusty and it didn't help; same results

[andreas.amann (andreas.amann-linux-kernel-bugs)]

This bug also occurs with my HP550 laptop. Wireless on this laptop worked well with kernel 3.10 (last tested) but stopped working as of 3.13 with precisely the same symptoms described above. As this is a clear regression, afix or at least some workaround would be much appreciated.

[adi (adi-linux-kernel-bugs)]

Andreas, Matthew's patch in <https://bugzilla.kernel.org/attachment.cgi?id=122901> does the trick for me (a workaround).

Have you tried it? Just apply it to the 3.13 or 3.14 kernel source.

[andreas.amann (andreas.amann-linux-kernel-bugs)]

I compiled a 3.14 kernel with Matthew's patch and I confirm that it works.
I now get:

# rfkill list
0: hp-wifi: Wireless LAN
 Soft blocked: no
 Hard blocked: no
1: phy0: Wireless LAN
 Soft blocked: no
 Hard blocked: no
2: hp-gps: GPS
 Soft blocked: yes
 Hard blocked: yes

while without the patch, only phy0 was listed and it was hard blocked. Pushing the wlan switch did not release the hard block. What is strange however is that when I now rebooted once more into the old kernel, I can now unblock wlan even in the old kernel (without the patch) using the hardware switch! Apparently something about the status of the wlan is stored between reboots?

Anyhow, it now works for me, thanks a lot for the patch!

[david.ward (david.ward-linux-kernel-bugs)]

Created attachment 186411
Test patch v2

Adrian and Andreas,

The patch that worked for both of you was sent to the mailing list, but changes were requested. Can you please test this new patch instead? This will help with getting a fix into the kernel. Thanks.

[eugene.shatokhin (eugene.shatokhin-linux-kernel-bugs)]

One of our users has a similar problem on HP 6730b laptop.

OS: ROSA Linux R7 x86_64, kernel 4.1.16.
The problem is seen with the kernel 4.4.3 as well.

'rfkill list' does not show hp-wifi, only phy0, and reports that WiFi is hard-blocked.

These kernels seem to have the first part of "Test patch v2" applied but miss the second hunk, namely:

-------------------
@@ -901,7 +906,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device)
  gps_rfkill = NULL;
  rfkill2_count = 0;

- if (hp_wmi_bios_2009_later() || hp_wmi_rfkill_setup(device))
+ if (hp_wmi_rfkill_setup(device))
   hp_wmi_rfkill2_setup(device);

  err = device_create_file(&device->dev, &dev_attr_display);
-------------------

I applied that hunk and rebuilt hp-wmi module. After reboot, it works OK: rfkill shows "hp-wifi" and WiFi can be blocked and unblocked by the appropriate key. Thanks!

Any chances to get that part of the patch to the mainline kernel too?

[peter.klotz99 (peter.klotz99-linux-kernel-bugs)]

Same here with a HP 620 laptop. The one-line patch mentioned in Comment 13 fixes WLAN blocking. Tested with 4.1.18 LTS kernel.

Mainlining (and then backporting it to LTS kernels) would be great.

[akhil.vaid (akhil.vaid-linux-kernel-bugs)]

I'm afraid I can't get this to work. I'm running the 4.4.5 kernel on an HP 15-ab032tx with the rtl8723be chipset.
I recompiled the hp-wmi module and;

Before suspending, I'm (still) getting:
# rfkill list all
0: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: no
1: hci0: Bluetooth
        Soft blocked: no
        Hard blocked: no

After suspending, this goes to:
# rfkill list all
0: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: yes

Can someone point me in the right direction?

[david.ward (david.ward-linux-kernel-bugs)]

(In reply to Akhil Vaid from comment #15)
> I'm afraid I can't get this to work. I'm running the 4.4.5 kernel on an HP
> 15-ab032tx with the rtl8723be chipset.
> I recompiled the hp-wmi module and;
>
> Before suspending, I'm (still) getting:
> # rfkill list all
> 0: phy0: Wireless LAN
> Soft blocked: no
> Hard blocked: no
> 1: hci0: Bluetooth
> Soft blocked: no
> Hard blocked: no
>
> After suspending, this goes to:
> # rfkill list all
> 0: phy0: Wireless LAN
> Soft blocked: no
> Hard blocked: yes
>
> Can someone point me in the right direction?

When you boot your laptop and do not suspend it, does your Wi-Fi adapter work? Did it also work this way before you recompiled the hp-wmi module? If so I believe you have a different issue and need to file a separate bug. Please let us know. If you think the patch in this bug report causes a regression for you, please clarify.

[akhil.vaid (akhil.vaid-linux-kernel-bugs)]

I'll walk through the chronology of running into this. I hope that's helpful.

The native kernel driver for the rtl8723be doesn't work very well. So I had to make do with a USB dongle, while also blacklisting the rtl8723be module. I was able to suspend and resume successfully with this setup; with the "airplane mode" key (The only WiFi related hardware switch on this machine) toggling *only* the soft block on rfkill status.

Sometime back, I discovered newer, functional dkms drivers for the rtl8723be. (Those are here: https://github.com/lwfinger/rtlwifi_new/tree/rock.new_btcoex. It seems other people have run into this too and the author of that repo also believes this interaction is because of the hp-wmi module.)

This was the first time I actually used the card under Linux, and incidentally also when I discovered the issue with suspending the laptop. I should also emphasize that before filing this bug report, I uninstalled the dkms driver. Apart from the recompiled hp-wmi module, my kernel is a vanilla 4.4.5-1-ARCH.

So, I've run through the following permutations:
1. Blacklisted rtl8723be. WiFi dongle: Suspend/Resume works. rfkill output is the same before and after suspending:
# rfkill list all
4: phy3: Wireless LAN
        Soft blocked: no
        Hard blocked: no

2. rtl8723be only: WiFi is no longer functional upon resuming. rfkill output is what I described before (With the recompiled kernel module AND without).
WiFi is functional after rebooting.

3. rtl8723be and WiFi dongle: Only the dongle is functional upon resuming. The WiFi card remains hard blocked according to rfkill. Again, a reboot restores normalcy.

[david.ward (david.ward-linux-kernel-bugs)]

(In reply to Akhil Vaid from comment #17)
> I'll walk through the chronology of running into this. I hope that's helpful.
>
> The native kernel driver for the rtl8723be doesn't work very well. So I had
> to make do with a USB dongle, while also blacklisting the rtl8723be module.
> I was able to suspend and resume successfully with this setup; with the
> "airplane mode" key (The only WiFi related hardware switch on this machine)
> toggling *only* the soft block on rfkill status.
>
> Sometime back, I discovered newer, functional dkms drivers for the
> rtl8723be. (Those are here:
> https://github.com/lwfinger/rtlwifi_new/tree/rock.new_btcoex. It seems other
> people have run into this too and the author of that repo also believes this
> interaction is because of the hp-wmi module.)
>
> This was the first time I actually used the card under Linux, and
> incidentally also when I discovered the issue with suspending the laptop. I
> should also emphasize that before filing this bug report, I uninstalled the
> dkms driver. Apart from the recompiled hp-wmi module, my kernel is a vanilla
> 4.4.5-1-ARCH.
>
> So, I've run through the following permutations:
> 1. Blacklisted rtl8723be. WiFi dongle: Suspend/Resume works. rfkill output
> is the same before and after suspending:
> # rfkill list all
> 4: phy3: Wireless LAN
> Soft blocked: no
> Hard blocked: no
>
> 2. rtl8723be only: WiFi is no longer functional upon resuming. rfkill output
> is what I described before (With the recompiled kernel module AND without).
> WiFi is functional after rebooting.
>
> 3. rtl8723be and WiFi dongle: Only the dongle is functional upon resuming.
> The WiFi card remains hard blocked according to rfkill. Again, a reboot
> restores normalcy.

I believe you should create a separate bug for your issue. This bug pertains to older HP laptops that are always hard blocked (even at initial boot), and it has a patch that has been tested to resolve that issue for these users.

[david.ward (david.ward-linux-kernel-bugs)]

Eugene (and Peter),

(In reply to Eugene A. Shatokhin from comment #13)
> OS: ROSA Linux R7 x86_64, kernel 4.1.16.
> The problem is seen with the kernel 4.4.3 as well.
>
> These kernels seem to have the first part of "Test patch v2" applied [...]

Are you sure? The first part of the patch is not included in either upstream kernel version you mentioned:

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/platform/x86/hp-wmi.c?h=v4.1.16#n716

https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/platform/x86/hp-wmi.c?h=v4.4.3#n716

Note that the first part of the patch adds a second call to hp_wmi_perform_query() that appears nearly identical to the existing call -- except the second parameter is different.

Can you please test with both parts of the patch applied?

[eugene.shatokhin (eugene.shatokhin-linux-kernel-bugs)]

(In reply to David Ward from comment #19)
> Eugene (and Peter),
>
> (In reply to Eugene A. Shatokhin from comment #13)
> > OS: ROSA Linux R7 x86_64, kernel 4.1.16.
> > The problem is seen with the kernel 4.4.3 as well.
> >
> > These kernels seem to have the first part of "Test patch v2" applied [...]
>
> Are you sure? The first part of the patch is not included in either upstream
> kernel version you mentioned:
>
>
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/
> drivers/platform/x86/hp-wmi.c?h=v4.1.16#n716
>
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/
> drivers/platform/x86/hp-wmi.c?h=v4.4.3#n716
>
>
> Note that the first part of the patch adds a second call to
> hp_wmi_perform_query() that appears nearly identical to the existing call --
> except the second parameter is different.

Ah, right. I did not notice it.

>
> Can you please test with both parts of the patch applied?

Yes, I'll prepare the kernel with the full patch and will ask our user to test it. I do not have such hardware myself unfortunately, so it might take several days.

[eugene.shatokhin (eugene.shatokhin-linux-kernel-bugs)]

I finally got my hands on that HP EliteBook 6930p. With the full patch, it works fine. I applied the patch to the kernel 4.1.19.

No problems with unblockable WiFi so far.

rfkill list:
0: phy0: Wireless LAN
    Soft blocked: no
    Hard blocked: no
1: hp-wifi: Wireless LAN
    Soft blocked: no
    Hard blocked: no
2: hp-bluetooth: Bluetooth
    Soft blocked: yes
    Hard blocked: no
3: hp-gps: GPS
    Soft blocked: yes
    Hard blocked: yes

"hp-wifi" and others are there now. Without the patch (either full or partial), they were missing.

More hardware info and the logs from that system, in case they are needed:
http://hw.rosalinux.ru/index.php?probe=9a383897a2

[samoht0-bugzilla (samoht0-bugzilla-linux-kernel-bugs)]

I'm (most likely) hit by this issue and filed a report in Fedora's bug-tracker:
https://bugzilla.redhat.com/show_bug.cgi?id=1338025

As Laura Abbott noted and I perfectly understand, the patch can't be add in Fedora without proper credits (Signed-off-by).

@David Ward
Would you mind to submit the "Test patch v2" with Signed-off-by included? Thanks in advance.

[david.ward (david.ward-linux-kernel-bugs)]

(In reply to samoht0 from comment #22)
> Would you mind to submit the "Test patch v2" with Signed-off-by included?

I can't take credit for it either. It is a subset of a patch originally posted by Alex Hung:

http://permalink.gmane.org/gmane.linux.drivers.platform.x86.devel/5205

(The rest of his patch has either already been applied, or it is no longer relevant due to other changes.)

[samoht0-bugzilla (samoht0-bugzilla-linux-kernel-bugs)]

Thanks for the reply and the further information. This situation is rather tricky.

At least, blacklisting hp_wmi works on my machine without side-effects.

[david.ward (david.ward-linux-kernel-bugs)]

The patch has been signed off by Alex Hung and submitted to the platform-driver-x86 mailing list:

http://permalink.gmane.org/gmane.linux.drivers.platform.x86.devel/9288

[david.ward (david.ward-linux-kernel-bugs)]

@Eugene, @Peter,

Since this patch has now been sent to the mailing list, would you be able to add your "Tested-by" tag (as described in https://www.kernel.org/doc/Documentation/SubmittingPatches ) to indicate that it fixes the problem for you? This will help it get accepted in the kernel.

The original message can be downloaded in raw form from here:
http://article.gmane.org/gmane.linux.drivers.platform.x86.devel/9288/raw

You can download this as a file, open it in your mail client (e.g. with Thunderbird, go to File > Open > Saved Message), and then click "Reply All".

[eugene.shatokhin (eugene.shatokhin-linux-kernel-bugs)]

(In reply to David Ward from comment #26)
> @Eugene, @Peter,
>
> Since this patch has now been sent to the mailing list, would you be able to
> add your "Tested-by" tag (as described in
> https://www.kernel.org/doc/Documentation/SubmittingPatches ) to indicate
> that it fixes the problem for you? This will help it get accepted in the
> kernel.

Sure. Done.

[david.ward (david.ward-linux-kernel-bugs)]

@Matthew Garrett: Please change status to "resolved" and resolution to "code fix".

Committed for v4.8: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fc8a601e1175ae351f662506030f9939cb7fdbfe

[David Ward (dpward)]

Upstream commit for v4.8: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fc8a601e1175ae351f662506030f9939cb7fdbfe