Comment 8 for bug 1102784

Revision history for this message
Colin Ian King (colin-king) wrote :

So, looking at the AML errors, I see:

line 2758: Name (_FDE, Package (0x05) // _FDE: Floppy Disk Enumerate
_FDE not used in the kernel, so this error can be ignored.

line 2897: This is a bug in the firmware, but I believe it won't do any harm.

line 4413: Method OCOP: Method does not return a package if non of the conditions are met. I doubt this is a bug, just sloppy coding.

line 5127: Method PROC: Method does not return a package if non of the conditions are met. I doubt this is a bug, just sloppy coding.

line 8862: Method SMBC: This does not release the mutex SMBA, so this is defintiely buggy firmware. However, I can't see any caller of this method, so nothing appears to be using it.

lines 11196, 11210, 11225, 11240, 11254, 11269, 11284: These ignore Mutex acquire timeout failures. Since the acquires block for 1 to 4.095 seconds you may just be lucky 99.9% of the time in that the AML code is fast to execute and any blocked threads never time out, so the races that occur in this buggy code never happen.

11801, 11846, 11908: Methods VGET, TGET, FGET: These methods may return bogus values if called incorrectly, however, the controls that call these methods aren't used by the kernel, so it won't ever fail.

So, apart from the firmware being pooly written, there is little to worry about.